Include rasterio for geotiff and wmts plotting by fso42 · Pull Request #1059 · OpenNHM/AvaFrame

fso42 · 2024-12-24T10:52:57Z

rename ascUtils to rasterUtils
add option to plot map background on peak plots

BEWARE: This PR leads to (minor) differences in the standard tests! This is due to the new remeshing and new file format! We will update the benchmarks in the next release and attach the report there.

TODOS:

look into https://rasterio.readthedocs.io/en/latest/topics/resampling.html
Solve llcorner vs llcenter when writing/reading ascii with rasterio...
readd ascUtils as deprecated
add info to doc (i.e. that results have same format as dem) -> Update docu for tif inclusion #1082

pep8speaks · 2024-12-24T10:53:25Z

Hello @fso42! Thanks for updating this PR.

In the file avaframe/ana1Tests/FPtest.py:

Line 148:76: E231 missing whitespace after ','
Line 95:21: E127 continuation line over-indented for visual indent

In the file avaframe/ana3AIMEC/aimecTools.py:

Line 1785:25: W292 no newline at end of file
Line 1767:68: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 1766:101: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 1764:74: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 1763:104: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 1761:67: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 1756:121: E501 line too long (124 > 120 characters)
Line 1696:37: E231 missing whitespace after ','
Line 1695:37: E231 missing whitespace after ','
Line 1694:66: E241 multiple spaces after ','
Line 1686:55: E225 missing whitespace around operator
Line 1685:55: E225 missing whitespace around operator
Line 1684:51: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1684:51: E225 missing whitespace around operator
Line 1683:45: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1683:45: E225 missing whitespace around operator
Line 1670:49: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1670:49: E225 missing whitespace around operator
Line 1659:53: E241 multiple spaces after ','
Line 1600:121: E501 line too long (139 > 120 characters)
Line 1497:19: E711 comparison to None should be 'if cond is not None:'
Line 1405:25: E711 comparison to None should be 'if cond is not None:'
Line 1156:121: E501 line too long (128 > 120 characters)
Line 1077:48: E231 missing whitespace after ','
Line 1076:72: E225 missing whitespace around operator
Line 1076:67: E231 missing whitespace after ','
Line 1076:26: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 1075:28: E225 missing whitespace around operator
Line 1072:47: E231 missing whitespace after ','
Line 1071:54: E231 missing whitespace after ','
Line 186:121: E501 line too long (131 > 120 characters)
Line 182:131: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 182:121: E501 line too long (140 > 120 characters)
Line 102:74: E231 missing whitespace after ','
Line 100:17: E225 missing whitespace around operator
Line 71:121: E501 line too long (124 > 120 characters)

In the file avaframe/ana3AIMEC/ana3AIMEC.py:

Line 670:5: E303 too many blank lines (2)
Line 624:9: E265 block comment should start with '# '
Line 615:13: E265 block comment should start with '# '
Line 613:64: E231 missing whitespace after ','
Line 613:38: E231 missing whitespace after ','
Line 610:62: E231 missing whitespace after ','
Line 609:62: E231 missing whitespace after ','
Line 524:121: E501 line too long (139 > 120 characters)
Line 499:66: E127 continuation line over-indented for visual indent
Line 496:121: E501 line too long (139 > 120 characters)
Line 471:65: E127 continuation line over-indented for visual indent
Line 468:121: E501 line too long (139 > 120 characters)
Line 460:121: E501 line too long (129 > 120 characters)
Line 391:121: E501 line too long (128 > 120 characters)
Line 383:121: E501 line too long (124 > 120 characters)
Line 379:121: E501 line too long (133 > 120 characters)
Line 358:121: E501 line too long (132 > 120 characters)
Line 214:121: E501 line too long (133 > 120 characters)
Line 181:13: E117 over-indented
Line 164:121: E501 line too long (124 > 120 characters)
Line 159:121: E501 line too long (128 > 120 characters)
Line 62:121: E501 line too long (128 > 120 characters)

In the file avaframe/ana4Stats/probAna.py:

Line 819:121: E501 line too long (129 > 120 characters)
Line 712:121: E501 line too long (135 > 120 characters)
Line 711:121: E501 line too long (167 > 120 characters)
Line 647:121: E501 line too long (127 > 120 characters)
Line 482:121: E501 line too long (128 > 120 characters)
Line 418:121: E501 line too long (125 > 120 characters)
Line 409:121: E501 line too long (121 > 120 characters)
Line 397:68: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 333:121: E501 line too long (125 > 120 characters)
Line 188:121: E501 line too long (135 > 120 characters)

In the file avaframe/ana5Utils/distanceTimeAnalysis.py:

Line 315:9: E265 block comment should start with '# '
Line 314:9: E265 block comment should start with '# '
Line 313:9: E265 block comment should start with '# '

In the file avaframe/com1DFA/com1DFA.py:

Line 2868:121: E501 line too long (132 > 120 characters)
Line 1311:59: E251 unexpected spaces around keyword / parameter equals
Line 1311:57: E251 unexpected spaces around keyword / parameter equals
Line 1311:51: E231 missing whitespace after ','
Line 1126:56: E231 missing whitespace after ','
Line 1125:40: E711 comparison to None should be 'if cond is None:'

In the file avaframe/com1DFA/deriveParameterSet.py:

Line 743:121: E501 line too long (130 > 120 characters)
Line 334:121: E501 line too long (126 > 120 characters)
Line 334:85: E712 comparison to False should be 'if cond is not False:' or 'if cond:'
Line 286:121: E501 line too long (132 > 120 characters)
Line 259:30: E225 missing whitespace around operator
Line 119:121: E501 line too long (128 > 120 characters)
Line 76:121: E501 line too long (127 > 120 characters)

In the file avaframe/com1DFAOrig/com1DFAOrig.py:

Line 462:5: E303 too many blank lines (2)
Line 448:121: E501 line too long (166 > 120 characters)
Line 436:9: E122 continuation line missing indentation or outdented
Line 435:9: E122 continuation line missing indentation or outdented
Line 393:29: E222 multiple spaces after operator
Line 390:121: E501 line too long (121 > 120 characters)
Line 388:121: E501 line too long (175 > 120 characters)
Line 385:121: E501 line too long (174 > 120 characters)
Line 337:33: E222 multiple spaces after operator
Line 332:121: E501 line too long (172 > 120 characters)
Line 318:121: E501 line too long (132 > 120 characters)
Line 318:94: E241 multiple spaces after ','
Line 309:21: E122 continuation line missing indentation or outdented
Line 308:21: E122 continuation line missing indentation or outdented
Line 159:42: E241 multiple spaces after ','

In the file avaframe/com2AB/com2AB.py:

Line 245:121: E501 line too long (127 > 120 characters)
Line 245:114: E222 multiple spaces after operator

In the file avaframe/com4FlowPy/com4FlowPy.py:

Line 484:38: W291 trailing whitespace
Line 481:13: E265 block comment should start with '# '
Line 480:13: E265 block comment should start with '# '
Line 318:121: E501 line too long (121 > 120 characters)

In the file avaframe/in1Data/getInput.py:

Line 860:52: E203 whitespace before ':'
Line 855:52: E203 whitespace before ':'
Line 772:36: E203 whitespace before ':'
Line 771:36: E203 whitespace before ':'
Line 479:45: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 466:18: E711 comparison to None should be 'if cond is not None:'
Line 422:46: E711 comparison to None should be 'if cond is not None:'
Line 419:33: E711 comparison to None should be 'if cond is not None:'
Line 409:43: E711 comparison to None should be 'if cond is None:'
Line 341:34: E711 comparison to None should be 'if cond is not None:'

In the file avaframe/in2Trans/rasterUtils.py:

Line 151:1: E302 expected 2 blank lines, found 1
Line 126:5: E303 too many blank lines (2)
Line 105:1: E302 expected 2 blank lines, found 1

In the file avaframe/in2Trans/transfromFields.py:

Line 84:1: W391 blank line at end of file

In the file avaframe/in3Utils/fileHandlerUtils.py:

Line 704:37: E262 inline comment should start with '# '
Line 704:36: E261 at least two spaces before inline comment
Line 677:121: E501 line too long (129 > 120 characters)
Line 35:88: W291 trailing whitespace

In the file avaframe/in3Utils/generateTopo.py:

Line 693:32: W291 trailing whitespace
Line 692:1: W293 blank line contains whitespace

In the file avaframe/in3Utils/geoTrans.py:

Line 1993:24: W292 no newline at end of file
Line 1987:5: E303 too many blank lines (2)
Line 1977:17: E231 missing whitespace after ','
Line 1976:17: E231 missing whitespace after ','
Line 1854:121: E501 line too long (126 > 120 characters)
Line 1685:70: W605 invalid escape sequence '|'
Line 1685:13: W605 invalid escape sequence '|'
Line 1684:69: W605 invalid escape sequence '\ '
Line 1684:12: W605 invalid escape sequence '\ '
Line 1683:68: W605 invalid escape sequence '\ '
Line 1683:11: W605 invalid escape sequence '\ '
Line 1682:67: W605 invalid escape sequence '\ '
Line 1682:10: W605 invalid escape sequence '\ '
Line 1680:65: W605 invalid escape sequence '|'
Line 1680:18: W605 invalid escape sequence '|'
Line 1679:64: W605 invalid escape sequence '\ '
Line 1679:17: W605 invalid escape sequence '\ '
Line 1678:63: W605 invalid escape sequence '\ '
Line 1678:16: W605 invalid escape sequence '\ '
Line 1677:62: W605 invalid escape sequence '\ '
Line 1677:15: W605 invalid escape sequence '\ '
Line 1663:1: E303 too many blank lines (3)
Line 1655:62: E231 missing whitespace after ','
Line 1655:49: E231 missing whitespace after ','
Line 1314:38: E203 whitespace before ':'
Line 1313:38: E203 whitespace before ':'
Line 1186:38: E203 whitespace before ':'
Line 1185:38: E203 whitespace before ':'
Line 419:5: E122 continuation line missing indentation or outdented
Line 360:1: E302 expected 2 blank lines, found 1
Line 325:121: E501 line too long (127 > 120 characters)
Line 174:1: E303 too many blank lines (3)

In the file avaframe/in3Utils/initializeProject.py:

Line 143:61: E231 missing whitespace after ','
Line 92:74: W291 trailing whitespace

In the file avaframe/out1Peak/outPlotAllPeak.py:

Line 289:121: E501 line too long (122 > 120 characters)
Line 210:25: E127 continuation line over-indented for visual indent
Line 209:121: E501 line too long (125 > 120 characters)
Line 201:121: E501 line too long (163 > 120 characters)
Line 201:93: E225 missing whitespace around operator
Line 124:121: E501 line too long (122 > 120 characters)

In the file avaframe/out3Plot/outContours.py:

Line 142:121: E501 line too long (125 > 120 characters)
Line 86:20: E231 missing whitespace after ','
Line 86:19: E203 whitespace before ','
Line 86:17: E231 missing whitespace after ','

In the file avaframe/out3Plot/outParticlesAnalysis.py:

Line 109:50: E241 multiple spaces after ','
Line 107:50: E241 multiple spaces after ','

In the file avaframe/out3Plot/outQuickPlot.py:

Line 489:121: E501 line too long (142 > 120 characters)
Line 489:84: E231 missing whitespace after ':'
Line 169:48: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 111:121: E501 line too long (147 > 120 characters)
Line 111:89: E231 missing whitespace after ':'

In the file avaframe/out3Plot/statsPlots.py:

Line 621:121: E501 line too long (129 > 120 characters)
Line 589:56: E251 unexpected spaces around keyword / parameter equals
Line 541:67: E231 missing whitespace after ','
Line 541:38: E231 missing whitespace after ','
Line 506:19: E225 missing whitespace around operator
Line 321:121: E501 line too long (158 > 120 characters)
Line 295:121: E501 line too long (127 > 120 characters)

In the file avaframe/runScripts/runParticleAnalysisPlots.py:

Line 133:121: E501 line too long (138 > 120 characters)
Line 95:1: E265 block comment should start with '# '
Line 94:121: E501 line too long (128 > 120 characters)
Line 41:1: E266 too many leading '#' for block comment
Line 31:1: E266 too many leading '#' for block comment

In the file avaframe/runScripts/runPlotProfile.py:

Line 83:1: W391 blank line at end of file
Line 70:38: E241 multiple spaces after ','
Line 56:97: E127 continuation line over-indented for visual indent
Line 22:1: E265 block comment should start with '# '
Line 3:52: W291 trailing whitespace

In the file avaframe/runScripts/runRangeTimeDiagram.py:

Line 124:55: E202 whitespace before ')'
Line 109:121: E501 line too long (123 > 120 characters)
Line 76:42: E201 whitespace after '('
Line 65:121: E501 line too long (129 > 120 characters)
Line 21:1: E265 block comment should start with '# '
Line 18:1: E265 block comment should start with '# '

In the file avaframe/runScripts/runThalwegTimeDiagram.py:

Line 67:121: E501 line too long (131 > 120 characters)
Line 25:1: E265 block comment should start with '# '
Line 22:1: E265 block comment should start with '# '

In the file avaframe/tests/test_aimecTools.py:

Line 277:1: W391 blank line at end of file
Line 268:55: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 267:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 266:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 265:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 264:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 247:5: E303 too many blank lines (2)
Line 243:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 242:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 241:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 240:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 223:5: E303 too many blank lines (2)
Line 217:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 216:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 215:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 214:51: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 205:40: E127 continuation line over-indented for visual indent
Line 156:121: E501 line too long (124 > 120 characters)
Line 148:1: E303 too many blank lines (3)
Line 143:5: E303 too many blank lines (2)
Line 133:121: E501 line too long (130 > 120 characters)
Line 132:121: E501 line too long (125 > 120 characters)

In the file avaframe/tests/test_ana3AIMEC.py:

Line 551:74: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

In the file avaframe/tests/test_com1DFA.py:

Line 783:44: W291 trailing whitespace
Line 782:37: W291 trailing whitespace
Line 782:24: E127 continuation line over-indented for visual indent
Line 765:43: W291 trailing whitespace
Line 764:37: W291 trailing whitespace
Line 764:24: E127 continuation line over-indented for visual indent
Line 747:43: W291 trailing whitespace
Line 746:37: W291 trailing whitespace
Line 746:24: E127 continuation line over-indented for visual indent
Line 696:44: W291 trailing whitespace
Line 695:35: W291 trailing whitespace
Line 695:24: E127 continuation line over-indented for visual indent
Line 233:37: E711 comparison to None should be 'if cond is None:'
Line 192:37: E711 comparison to None should be 'if cond is None:'

In the file avaframe/tests/test_distanceTimeAnalysis.py:

Line 424:121: E501 line too long (172 > 120 characters)
Line 423:80: E231 missing whitespace after ','
Line 414:5: E303 too many blank lines (2)
Line 403:121: E501 line too long (153 > 120 characters)
Line 402:78: E231 missing whitespace after ','
Line 315:1: E303 too many blank lines (3)

In the file avaframe/tests/test_geoTrans.py:

Line 1172:1: E302 expected 2 blank lines, found 1
Line 604:5: E303 too many blank lines (2)

In the file avaframe/tests/test_getInput.py:

Line 513:5: E303 too many blank lines (2)
Line 449:73: E231 missing whitespace after ','
Line 419:5: E303 too many blank lines (2)
Line 385:5: E303 too many blank lines (2)
Line 363:1: E303 too many blank lines (4)
Line 355:5: E303 too many blank lines (2)
Line 321:54: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 319:55: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 318:54: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 277:19: E222 multiple spaces after operator
Line 241:19: E222 multiple spaces after operator
Line 207:19: E222 multiple spaces after operator
Line 197:39: E711 comparison to None should be 'if cond is None:'
Line 193:37: E711 comparison to None should be 'if cond is None:'
Line 188:121: E501 line too long (150 > 120 characters)
Line 181:5: E303 too many blank lines (2)
Line 177:37: E225 missing whitespace around operator
Line 177:29: E225 missing whitespace around operator
Line 146:5: E303 too many blank lines (2)
Line 73:19: E222 multiple spaces after operator
Line 24:1: E302 expected 2 blank lines, found 1

In the file avaframe/tests/test_outDistanceTimeAnalysis.py:

Line 68:121: E501 line too long (147 > 120 characters)
Line 65:85: E231 missing whitespace after ','
Line 64:39: E225 missing whitespace around operator
Line 49:121: E501 line too long (123 > 120 characters)
Line 47:5: E303 too many blank lines (2)
Line 40:31: E231 missing whitespace after ','
Line 28:9: E116 unexpected indentation (comment)
Line 23:38: E225 missing whitespace around operator

In the file avaframe/tests/test_outParticlesAnalysis.py:

Line 76:12: E231 missing whitespace after ','
Line 75:5: E303 too many blank lines (2)
Line 72:16: E231 missing whitespace after ','
Line 71:16: E231 missing whitespace after ','
Line 70:5: E303 too many blank lines (2)
Line 67:13: E231 missing whitespace after ','
Line 66:13: E231 missing whitespace after ','
Line 63:26: E231 missing whitespace after ','
Line 62:26: E231 missing whitespace after ','
Line 59:14: E231 missing whitespace after ','
Line 58:14: E231 missing whitespace after ','
Line 31:12: E231 missing whitespace after ','
Line 28:26: E231 missing whitespace after ','
Line 27:26: E231 missing whitespace after ','
Line 26:26: E231 missing whitespace after ','
Line 25:26: E231 missing whitespace after ','
Line 22:14: E231 missing whitespace after ','
Line 21:14: E231 missing whitespace after ','

In the file avaframe/tests/test_particleInitialisation.py:

Line 139:121: E501 line too long (129 > 120 characters)
Line 117:32: E231 missing whitespace after ','
Line 106:48: E127 continuation line over-indented for visual indent

In the file avaframe/tests/test_plotUtils.py:

Line 284:1: W391 blank line at end of file
Line 283:121: E501 line too long (142 > 120 characters)
Line 279:5: E303 too many blank lines (2)
Line 266:121: E501 line too long (123 > 120 characters)
Line 263:23: E231 missing whitespace after ','
Line 251:31: E221 multiple spaces before operator
Line 249:31: E221 multiple spaces before operator
Line 245:15: E711 comparison to None should be 'if cond is not None:'
Line 229:31: E225 missing whitespace around operator
Line 229:25: E231 missing whitespace after ','
Line 229:5: E303 too many blank lines (2)
Line 222:36: E231 missing whitespace after ','
Line 220:26: E231 missing whitespace after ','
Line 220:23: E231 missing whitespace after ','
Line 219:24: E231 missing whitespace after ','
Line 219:22: E231 missing whitespace after ','
Line 219:20: E231 missing whitespace after ','
Line 207:61: E241 multiple spaces after ','
Line 207:57: E241 multiple spaces after ','
Line 207:49: E241 multiple spaces after ','
Line 207:45: E241 multiple spaces after ','
Line 200:121: E501 line too long (121 > 120 characters)
Line 184:121: E501 line too long (121 > 120 characters)
Line 173:121: E501 line too long (121 > 120 characters)
Line 151:23: E711 comparison to None should be 'if cond is None:'
Line 139:5: E303 too many blank lines (2)
Line 129:36: E231 missing whitespace after ','
Line 128:36: E231 missing whitespace after ','
Line 127:36: E231 missing whitespace after ','
Line 126:39: E231 missing whitespace after ','
Line 102:22: E711 comparison to None should be 'if cond is None:'
Line 101:22: E711 comparison to None should be 'if cond is None:'
Line 80:5: E303 too many blank lines (2)
Line 76:69: E221 multiple spaces before operator
Line 51:29: E231 missing whitespace after ','
Line 18:18: E231 missing whitespace after ','
Line 17:29: E231 missing whitespace after ','

In the file avaframe/tests/test_runD2Th.py:

Line 57:1: W391 blank line at end of file
Line 42:17: E225 missing whitespace around operator

Comment last updated at 2025-01-09 16:22:50 UTC

avaframe/out1Peak/outPlotAllPeak.py

avaframe/in3Utils/geoTrans.py

avaframe/in2Trans/rasterUtils.py

avaframe/out3Plot/outQuickPlot.py

qlty-cloud-legacy

The PR diff size of 5797 lines exceeds the maximum allowed for the inline comments feature.

avaframe/ana1Tests/simiSolTest.py

avaframe/ana1Tests/testUtilities.py

avaframe/avaframeCfg.ini

avaframe/in2Trans/rasterUtils.py

avaframe/out3Plot/outQuickPlot.py

avaframe/runScripts/runD2Th.py

avaframe/runStandardTestsCom1DFA.py

avaframe/tests/data/testSim/releaseTest1_0.888_entres_dfa_ppr.asc

avaframe/tests/data/testSim1/releaseTest1_test_AF_0.888_entres_dfa_ppr.asc

qlty-cloud-legacy

The PR diff size of 8415 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 8415 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 8777 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 9957 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 10077 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 10329 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 10325 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 10328 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 10349 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 10374 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 10520 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 10520 lines exceeds the maximum allowed for the inline comments feature.

- add basemap to plot; rename ascUtils to rasterUtils - start inclusion of geotiff; working commit, squash - add cropshape option in plotAll - add alr tif

- rework new remesh to reproduce old remeshing - update reference remesh file for pytest test_geoTrans - remove unecessary code and test -> if raster is found with correct size, it already returns. There is no need for an overwrite then

- Fixes deriveParameterSet pytests - make search for sim and comp file (standard test) tif compatible - add pytest-mock to runTestSinglePython.yml action - This commit also updates the Code Climate action to version 9.0.0. - add check if CRS is none if online background flag is true - error BREAKING CHANGES: Removed the `plotASCwithWmts` function and the `plotPeaksWithMap.py` file. This functionality is no longer required. Improve input file handling: adds 'raster' option to getAndCheckInputFiles add getInput pytests

qlty-cloud-legacy

The PR diff size of 10520 lines exceeds the maximum allowed for the inline comments feature.

avaframe/in3Utils/geoTrans.py

This commit readds the `ascUtils` module, which provides functionality for reading and writing ASCII grid files. All functions include deprecation warnings, directing users to the `rasterUtils` module for replacements.

qlty-cloud-legacy

The PR diff size of 10358 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy · 2025-02-06T08:30:18Z

Code Climate has analyzed commit 342a0b5 and detected 11 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	3
Duplication	8

The test coverage on the diff in this pull request is 72.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.3%.

View more on Code Climate.

fso42 added the enhancement New feature or request label Dec 24, 2024

fso42 self-assigned this Dec 24, 2024

fso42 force-pushed the addGdalStuff branch from 1737571 to 403cb3e Compare January 22, 2025 11:28

qlty-cloud-legacy bot reviewed Jan 23, 2025

View reviewed changes

avaframe/out1Peak/outPlotAllPeak.py Show resolved Hide resolved

avaframe/in3Utils/geoTrans.py Outdated Show resolved Hide resolved

avaframe/in2Trans/rasterUtils.py Show resolved Hide resolved

fso42 added this to the Version 1.10 milestone Jan 23, 2025

qlty-cloud-legacy bot reviewed Jan 23, 2025

View reviewed changes

avaframe/out3Plot/outQuickPlot.py Show resolved Hide resolved

avaframe/out3Plot/outQuickPlot.py Show resolved Hide resolved

fso42 marked this pull request as ready for review January 24, 2025 08:19

fso42 requested a review from awirb January 24, 2025 08:20

qlty-cloud-legacy bot reviewed Jan 24, 2025

View reviewed changes

awirb requested changes Jan 26, 2025

View reviewed changes

qlty-cloud-legacy bot reviewed Jan 27, 2025

View reviewed changes

fso42 force-pushed the addGdalStuff branch from bcf1ced to 1c65ac8 Compare January 27, 2025 12:57

qlty-cloud-legacy bot reviewed Jan 27, 2025

View reviewed changes

qlty-cloud-legacy bot reviewed Jan 28, 2025

View reviewed changes

qlty-cloud-legacy bot reviewed Jan 29, 2025

View reviewed changes

fso42 mentioned this pull request Jan 29, 2025

Add geopackage support for input / output #735

Closed

qlty-cloud-legacy bot reviewed Jan 29, 2025

View reviewed changes

qlty-cloud-legacy bot reviewed Jan 30, 2025

View reviewed changes

fso42 force-pushed the addGdalStuff branch from 3186d3d to 2392a0f Compare February 4, 2025 07:37

qlty-cloud-legacy bot reviewed Feb 4, 2025

View reviewed changes

fso42 and others added 3 commits February 4, 2025 09:55

Add gdal related dependencies. rasterio, geopandas, fiona

230cf72

- add basemap to plot; rename ascUtils to rasterUtils - start inclusion of geotiff; working commit, squash - add cropshape option in plotAll - add alr tif

Add resampling using rasterio

b3048d0

- rework new remesh to reproduce old remeshing - update reference remesh file for pytest test_geoTrans - remove unecessary code and test -> if raster is found with correct size, it already returns. There is no need for an overwrite then

fso42 force-pushed the addGdalStuff branch from 2392a0f to 2e11f3d Compare February 4, 2025 08:55

qlty-cloud-legacy bot reviewed Feb 4, 2025

View reviewed changes

awirb approved these changes Feb 4, 2025

View reviewed changes

avaframe/in3Utils/geoTrans.py Show resolved Hide resolved

fso42 mentioned this pull request Feb 5, 2025

Handle default epsg better? #1083

Open

feat(in2Trans): readd ascUtils module (addGdalStuff)

342a0b5

This commit readds the `ascUtils` module, which provides functionality for reading and writing ASCII grid files. All functions include deprecation warnings, directing users to the `rasterUtils` module for replacements.

fso42 force-pushed the addGdalStuff branch from af17794 to 342a0b5 Compare February 6, 2025 08:17

qlty-cloud-legacy bot reviewed Feb 6, 2025

View reviewed changes

fso42 merged commit 2cc482b into master Feb 6, 2025
4 checks passed

fso42 deleted the addGdalStuff branch February 6, 2025 10:13

Conversation

fso42 commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pep8speaks commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2025-01-09 16:22:50 UTC

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot commented Feb 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fso42 commented Dec 24, 2024 •

edited

Loading

pep8speaks commented Dec 24, 2024 •

edited

Loading