Skip to content

fix com2AB multiple lines issue [com2]#1060

Merged
fso42 merged 1 commit intomasterfrom
com2MultipleLines
Jan 8, 2025
Merged

fix com2AB multiple lines issue [com2]#1060
fso42 merged 1 commit intomasterfrom
com2MultipleLines

Conversation

@leon-wagner
Copy link
Contributor

@leon-wagner leon-wagner commented Jan 7, 2025

fixes #1057

@leon-wagner leon-wagner requested a review from fso42 January 7, 2025 14:20
@leon-wagner leon-wagner linked an issue Jan 7, 2025 that may be closed by this pull request
@leon-wagner leon-wagner added the confirmed Something isn't working label Jan 7, 2025
@pep8speaks
Copy link

pep8speaks commented Jan 7, 2025

Hello @leon-wagner! Thanks for updating this PR.

Line 251:121: E501 line too long (127 > 120 characters)
Line 251:114: E222 multiple spaces after operator
Line 106:26: E262 inline comment should start with '# '
Line 106:25: E261 at least two spaces before inline comment

Line 188:24: E261 at least two spaces before inline comment
Line 187:23: E261 at least two spaces before inline comment
Line 186:9: E265 block comment should start with '# '
Line 47:1: E303 too many blank lines (3)

Comment last updated at 2025-01-08 13:13:34 UTC

@leon-wagner leon-wagner changed the title fix #1057 fix com2AB multiple lines issue Jan 7, 2025
@leon-wagner leon-wagner marked this pull request as ready for review January 7, 2025 14:24
@fso42 fso42 added this to the Version 1.10 milestone Jan 8, 2025
Copy link
Contributor

@fso42 fso42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the pytest to reflect the "line" name

@fso42 fso42 assigned fso42 and unassigned leon-wagner Jan 8, 2025
adjust pytest to account for other line names
@fso42 fso42 force-pushed the com2MultipleLines branch from 075ba4a to e5af36f Compare January 8, 2025 13:13
@fso42 fso42 changed the title fix com2AB multiple lines issue fix com2AB multiple lines issue [com2] Jan 8, 2025
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit e5af36f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.5% (0.0% change).

View more on Code Climate.

@fso42
Copy link
Contributor

fso42 commented Jan 8, 2025

Standardtests ok, apart from know Kot and Hof

@fso42 fso42 merged commit 86e5789 into master Jan 8, 2025
1 check passed
@fso42 fso42 deleted the com2MultipleLines branch January 8, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

confirmed Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

com2AB Problem with multiple lines but no name attribute

3 participants