Skip to content

[com4]: change variable and function names containg "_" to camelCase#1070

Closed
PaulaSp3 wants to merge 1 commit intomasterfrom
PS_FP_minorImprovements
Closed

[com4]: change variable and function names containg "_" to camelCase#1070
PaulaSp3 wants to merge 1 commit intomasterfrom
PS_FP_minorImprovements

Conversation

@PaulaSp3
Copy link
Contributor

I changed to most variable and function names to camelCase except a few, for those the "_" suits better IMO, e.g. is_start and calc_zDelta()

@PaulaSp3 PaulaSp3 linked an issue Jan 20, 2025 that may be closed by this pull request
2 tasks
@pep8speaks
Copy link

Hello @PaulaSp3! Thanks for opening this PR.

Line 616:13: E265 block comment should start with '# '
Line 615:13: E265 block comment should start with '# '
Line 343:121: E501 line too long (121 > 120 characters)

Line 121:5: E722 do not use bare 'except'
Line 112:5: E722 do not use bare 'except'
Line 87:5: E722 do not use bare 'except'

Do see the Hitchhiker's guide to code style

@PaulaSp3 PaulaSp3 requested a review from ahuber-bfw January 20, 2025 10:40
@PaulaSp3 PaulaSp3 closed this Jan 21, 2025
@PaulaSp3 PaulaSp3 deleted the PS_FP_minorImprovements branch January 21, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[com4FlowPy]: minor improvements

3 participants