Skip to content

[com1; in3] save files during run; enable to resume computation if interrupted #1078

Merged
fso42 merged 3 commits intomasterfrom
saveFiles
Mar 27, 2025
Merged

[com1; in3] save files during run; enable to resume computation if interrupted #1078
fso42 merged 3 commits intomasterfrom
saveFiles

Conversation

@awirb
Copy link
Contributor

@awirb awirb commented Jan 28, 2025

…for mult sims

@awirb awirb requested a review from fso42 January 28, 2025 11:32
@fso42 fso42 mentioned this pull request Jan 28, 2025
@fso42 fso42 added the enhancement New feature or request label Feb 4, 2025
@fso42 fso42 modified the milestones: Version 1.11, Version 1.12 Feb 4, 2025
@awirb awirb requested a review from fso42 February 5, 2025 13:16
@fso42 fso42 linked an issue Feb 6, 2025 that may be closed by this pull request
@fso42 fso42 changed the title save files during run and allow to resume computation if interrupted … [com1; in3] save files during run; enable to resume computation if interrupted Feb 7, 2025
@awirb awirb force-pushed the saveFiles branch 2 times, most recently from 2dc0fab to d2c1253 Compare February 26, 2025 08:53
@fso42
Copy link
Contributor

fso42 commented Feb 26, 2025

What I just realized: The function and functionality of appendFieldsParticles is then removed.

  • Does that influence the thalweg time stuff (or similar things?)
  • should we add this as an option (by default off)

Copy link
Contributor

@fso42 fso42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an information (content/purpose) about the configurationFilesX folder here:
https://docs.avaframe.org/en/latest/moduleCom1DFA.html#output

Copy link
Contributor

@fso42 fso42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed: please change location of done and latest folder

@fso42
Copy link
Contributor

fso42 commented Mar 13, 2025

Windows ok

@qltysh
Copy link
Contributor

qltysh bot commented Mar 26, 2025

All good ✅

awirb added 2 commits March 27, 2025 11:29
…for mult sims

add reading simDF from configurationFilesDone folder
add saving 0, and last time step of particle
read existing simDF and append to current simDF
add where configuration info for simDF is read from
add new option to read config from
add tests
remove file ending
 - add info to docu
 - rename to configurationFilesLatest folder
@qltysh
Copy link
Contributor

qltysh bot commented Mar 27, 2025

Diff Coverage: The code coverage on the diff in this pull request is 84.8%.

Total Coverage: This PR will increase coverage by 0.1%.

File Coverage Changes
Path File Coverage Δ Indirect
avaframe/com1DFA/com1DFA.py 0.1
avaframe/com1DFA/com1DFATools.py 0.1
avaframe/com1DFA/particleTools.py -0.7
avaframe/in3Utils/cfgUtils.py 0.6
avaframe/in3Utils/initializeProject.py -0.1
avaframe/out3Plot/outCom1DFA.py 2.2
avaframe/out3Plot/plotUtils.py 0.3
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit eaefd15 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

The test coverage on the diff in this pull request is 84.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 70.1% (0.0% change).

View more on Code Climate.

@fso42
Copy link
Contributor

fso42 commented Mar 27, 2025

Standardtests ident

@fso42 fso42 merged commit e1e42e9 into master Mar 27, 2025
6 checks passed
@fso42 fso42 deleted the saveFiles branch March 27, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write timesteps directly instead of keeping in memory

2 participants