Skip to content

[com4FlowPy] minor Bugfix, documentation update and added feature for "forestFriciton", "forestDetrainment" and "forestFrictionLayer" model options#1087

Merged
fso42 merged 1 commit intomasterfrom
AH_com4FlowPy_PR1071
Feb 20, 2025
Merged

[com4FlowPy] minor Bugfix, documentation update and added feature for "forestFriciton", "forestDetrainment" and "forestFrictionLayer" model options#1087
fso42 merged 1 commit intomasterfrom
AH_com4FlowPy_PR1071

Conversation

@ahuber-bfw
Copy link
Contributor

@ahuber-bfw ahuber-bfw commented Feb 12, 2025

Exact copy of PR #1071 on top of current master branch.

+++++++++++++++++++

Original PR content:

  • fixed minor bug in runCom4FlowPy.py that caused an unhandled exception if the workDir did not exist a priori with useCustomPaths option set to True
  • updated com4FlowPy documentation (additional references, and small changes)
  • new Feature/modelOption skipForestDist:
    • skipForestDist allows the definition of a length [m] along the track (calculated in X,Y,Z and not in projected distances X,Y- to account for different track inclinations) that needs to be surpassed, before added forestFriction is modeled. This affects all forestFriction related code if forestFriction, forestFrictionLayer or forestDetrainment are selected.
    • the feature allows to define an "initial acceleration distance" for GMFs that release in or directly above dense forest and should provide a mechanism to prevent potential under-estimation of GMF runouts in these cases.
    • By leaving the default value skipForestDist = 0 the prior model behavior remains unchanged.
  • note: This makes the code ~ 5% to 10% slower in first tests

@ahuber-bfw ahuber-bfw added confirmed Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Feb 12, 2025
@ahuber-bfw ahuber-bfw requested a review from fso42 February 12, 2025 12:58
@fso42 fso42 changed the title [com4FlowPy] manually applied PR #1071 on top of current master [com4FlowPy] minor Bugfix, documentation update and added feature for "forestFriciton", "forestDetrainment" and "forestFrictionLayer" model options Feb 12, 2025
@fso42 fso42 added this to the Version 1.12 milestone Feb 12, 2025
@fso42 fso42 force-pushed the AH_com4FlowPy_PR1071 branch from 8694a8f to 022f69c Compare February 19, 2025 14:42
@fso42
Copy link
Contributor

fso42 commented Feb 20, 2025

Standardtests ok

@fso42 fso42 force-pushed the AH_com4FlowPy_PR1071 branch from 022f69c to 02a2b1d Compare February 20, 2025 09:18
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 02a2b1d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 8.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 70.3%.

View more on Code Climate.

@fso42 fso42 merged commit 4a0257c into master Feb 20, 2025
3 of 4 checks passed
@fso42 fso42 deleted the AH_com4FlowPy_PR1071 branch February 20, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

confirmed Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants