[com4]: all output rasters have value -9999 in not affected cells

[PaulaSp3]

• There is a new parameter in the (local_)com4FlowPyCfg.ini outputNoDataValue (default: -9999) that defines the nodata value for the output rasters
• Then ALL output rasters have the same value in cells taht are not affected by the process (default -9999)
• I've tested in one example, if all -9999 values are at the same locations in every output-raster.
• A further question/ issue?: Should we initialize the rasterArrays consistently? (see Issue#1165)
• All rasters that are saved as tif - files are LZW compressed. In the config file compressing can be switched off.

[ahuber-bfw]

Maybe changes are only necessary in com4FlowPyCfg.ini, runCom4FlowPy.py and com4FlowPy.py if we simply provide the cell_counts raster to the defineNotAffectedCells() function in com4FlowPy.mergeAndWriteResults()

sth. like zDelta = defineNotAffectedCells(raster = zDelta, affectedCells = cellCounts, noDataValue = _outputNoDataValue)

[ahuber-bfw]

Looks good and a lot more compact now :)

Maybe we can wait for PR #1173 to be merged and then also resolve issue #1178 in this PR? (adding an .ini option for disabling .tif compression) $\rightarrow$ this would also only require minor changes to (local)com4FlowPyCfg.ini, runCom4FlowPy.py and com4FlowPy.py

regarding issue #1165 I need to have a closer look still ;) - so maybe could be included in a further PR.

[qltysh]

Diff Coverage: The code coverage on the diff in this pull request is 0.0%.

Total Coverage: This PR will decrease coverage by 0.09%.

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

[ahuber-bfw]

Passt soweit und funktioniert bei mir lokal, nur den 1-Zeilen comment in com4FlowPy.py (line549) bitte noch einbauen

[fso42]

Standardtest ident