Conversation
awirb
approved these changes
Nov 21, 2025
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (1)
🛟 Help
|
fso42
requested changes
Nov 24, 2025
PaulaSp3
commented
Nov 24, 2025
fso42
approved these changes
Nov 25, 2025
Contributor
fso42
requested changes
Dec 1, 2025
Contributor
fso42
left a comment
There was a problem hiding this comment.
2 points from me, and the qlty comments should be addressed as well
fso42
approved these changes
Dec 2, 2025
fso42
approved these changes
Dec 9, 2025
todo comment update input data type com1DFA add comment about nodata values add either or tests/test_deriveParameterSet.py change layout add comments add more info
Contributor
|
Standardtests ident |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thicknessFromShpdoes not exist any morecode changes: