Skip to content

[com1]: write time depedent release infos into report#1240

Merged
fso42 merged 1 commit intomasterfrom
PS_reportTimeDepRel
Feb 19, 2026
Merged

[com1]: write time depedent release infos into report#1240
fso42 merged 1 commit intomasterfrom
PS_reportTimeDepRel

Conversation

@PaulaSp3
Copy link
Contributor

@PaulaSp3 PaulaSp3 commented Feb 16, 2026

When time dependent release is switched on the report looks like:

Screenshot from 2026-02-16 18-22-53 (added detrained mass, initialized mass, release thickness summed over time steps, and release volume summed over timesteps)

@PaulaSp3 PaulaSp3 self-assigned this Feb 16, 2026
@PaulaSp3 PaulaSp3 added enhancement New feature or request DebrisFrame labels Feb 16, 2026
@PaulaSp3 PaulaSp3 force-pushed the PS_reportTimeDepRel branch from 7991e58 to b4cff10 Compare February 16, 2026 17:48
@qltysh
Copy link
Contributor

qltysh bot commented Feb 16, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA80.0%

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py80.0%546, 1012, 3713
Coverage rating: B Coverage rating: B
avaframe/log2Report/generateReport.py100.0%
Total81.3%
🤖 Increase coverage with AI coding...

In the `PS_reportTimeDepRel` branch, add test coverage for this new code:

- `avaframe/com1DFA/com1DFA.py` -- Lines 546, 1012, and 3713

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@PaulaSp3 PaulaSp3 force-pushed the PS_reportTimeDepRel branch 2 times, most recently from a7d9881 to d62b448 Compare February 17, 2026 07:50
@PaulaSp3 PaulaSp3 requested review from awirb and fso42 February 17, 2026 07:51
Copy link
Contributor

@awirb awirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be helpful in the report to also explicitly state that is of a time dependent release - either add a releaseAreaType beneath Release Area Scenario or in the section Release Area add this info there

@PaulaSp3 PaulaSp3 force-pushed the PS_reportTimeDepRel branch from c1e8c34 to e8dff89 Compare February 17, 2026 10:15
@PaulaSp3 PaulaSp3 force-pushed the PS_reportTimeDepRel branch from e8dff89 to f8e0687 Compare February 19, 2026 08:12
@PaulaSp3 PaulaSp3 requested a review from fso42 February 19, 2026 09:02
@PaulaSp3 PaulaSp3 assigned fso42 and unassigned PaulaSp3 Feb 19, 2026
adapt tests

adapt test

rename report column

adapt test

without time dependent release no change in release area part

avoid numpy array in release Dict

update test
@fso42 fso42 force-pushed the PS_reportTimeDepRel branch from b7620aa to 61ccab2 Compare February 19, 2026 10:23
@fso42 fso42 added this to the Version 2.0 milestone Feb 19, 2026
@fso42
Copy link
Contributor

fso42 commented Feb 19, 2026

Standardtests ident

@fso42 fso42 merged commit e9e7cb5 into master Feb 19, 2026
4 checks passed
@fso42 fso42 deleted the PS_reportTimeDepRel branch February 19, 2026 10:50
@fso42
Copy link
Contributor

fso42 commented Feb 19, 2026

Standardtests ident

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DebrisFrame enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add time dependent release info to output report Where do we need info about the whole release mass (and not just from the initial time step)?

3 participants