Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Update fortawesome icons from 6.4.2 to 6.5.2 #7488

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

atif1019
Copy link

Description

Update fortawesome free-solid-svg-icons icons from 6.4.2 to 6.5.2 in develop.

The dependabot PRs are for foundation-2024 branch, however let's try just doing this in develop first.

There are build errors that must be fixed. Also, need to manually test that icons are showing up correctly in both Vue and classic/JSP web pages.

build(deps): bump @fortawesome/free-solid-svg-icons from 6.4.2 to 6.5.2 in /ui by dependabot[bot] · Pull Request #7205 · OpenNMS/opennms
bump @fortawesome/free-solid-svg-icons from 6.4.2 to 6.5.2 in core/web-assets

build(deps): bump @fortawesome/free-solid-svg-icons from 6.4.2 to 6.6.0 in /ui by dependabot[bot] · Pull Request #7373 · OpenNMS/opennms
bump @fortawesome/free-solid-svg-icons from 6.4.2 to 6.6.0 in /ui

Copy link
Contributor

@synqotik synqotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indenting back to what it was before, then I can re-review.

Copy link
Contributor

@synqotik synqotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants