Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMS-16573 User tries to create an Alarm filter favorite, but the filter doesn't save the arguments of the filter #7596

Open
wants to merge 2 commits into
base: foundation-2023
Choose a base branch
from
Open

NMS-16573 User tries to create an Alarm filter favorite, but the filter doesn't save the arguments of the filter #7596

wants to merge 2 commits into from
+105 −1

Conversation

jahanzebdataq
Copy link
Contributor

External References

cgorantla
cgorantla reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried to reproduce this issue, but if you tested this with the scenario mentioned in the bug, looks fine to me.

opennms-webapp/src/main/java/org/opennms/web/alarm/AlarmUtil.java Show resolved Hide resolved
cgorantla
cgorantla approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgorantla cgorantla cgorantla approved these changes

@fooker fooker Awaiting requested review from fooker

@smunir-onms smunir-onms Awaiting requested review from smunir-onms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jahanzebdataq @cgorantla @smunir-onms