fix(app): Use our own Markdown component that sanitizes HTML following GitHub-like rules #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2982 +/- ##
==========================================
+ Coverage 64.91% 65.15% +0.23%
==========================================
Files 379 380 +1
Lines 24320 24487 +167
Branches 877 878 +1
==========================================
+ Hits 15787 15954 +167
Misses 8533 8533 ☔ View full report in Codecov by Sentry. |
nellh
changed the title
effigies
reviewed
Jan 24, 2024
packages/openneuro-app/src/scripts/utils/__tests__/__snapshots__/markdown.spec.tsx.snap
Show resolved
Hide resolved
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
effigies
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes through the raw HTML strings instead of parsing it as JSX if present. All HTML will be displayed as raw text.
See #2873