Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Limit validation to 50k issues #3277

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix(server): Limit validation to 50k issues #3277

merged 1 commit into from
Jan 15, 2025

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Jan 15, 2025

Prevents failing to report validation for datasets with larger than 16MB BSON issues.

We may remove this limit if the upstream validator provides a less verbose output.

Prevents failing to report validation for datasets with larger than 16MB BSON issues.
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.85%. Comparing base (794f576) to head (ddfd375).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...enneuro-server/src/graphql/resolvers/validation.ts 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3277      +/-   ##
==========================================
- Coverage   46.85%   46.85%   -0.01%     
==========================================
  Files         610      610              
  Lines       39102    39111       +9     
  Branches     1254     1255       +1     
==========================================
+ Hits        18321    18325       +4     
- Misses      20585    20590       +5     
  Partials      196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit c7f909d into master Jan 15, 2025
13 of 15 checks passed
@nellh nellh deleted the validation-limit branch January 15, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant