feat: Demote PARTICIPANT_ID_MISMATCH to a warning for now#3320
Merged
nellh merged 6 commits intoOpenNeuroOrg:masterfrom Feb 12, 2025
Merged
feat: Demote PARTICIPANT_ID_MISMATCH to a warning for now#3320nellh merged 6 commits intoOpenNeuroOrg:masterfrom
nellh merged 6 commits intoOpenNeuroOrg:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3320 +/- ##
==========================================
+ Coverage 47.21% 48.15% +0.93%
==========================================
Files 591 595 +4
Lines 37768 38031 +263
Branches 1243 1295 +52
==========================================
+ Hits 17834 18315 +481
+ Misses 19747 19538 -209
+ Partials 187 178 -9 ☔ View full report in Codecov by Sentry. |
5fcc2dc to
2be2eda
Compare
Contributor
Author
effigies
commented
Feb 12, 2025
Contributor
Author
There was a problem hiding this comment.
I guess we could symlink this one too, then?
Contributor
There was a problem hiding this comment.
I tried to get that to work but gave up on it. I've also had to go back to using a non-symlinked one for the JSR CLI, so there's just going to be several copies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing problems with https://openneuro.org/datasets/ds005752/ that can't be reasonably resolved within the dataset. This is quite a minor issue, and we can hopefully get rid of this exception soon.