Progressive loading for schema validator output#3322
Merged
Conversation
thinknoack
approved these changes
Feb 11, 2025
Contributor
thinknoack
left a comment
There was a problem hiding this comment.
reviewing the app locally looks good. I see loading animations for both draft and snapshots. Code looks good, tests pass, and no lint issues.
fix(app): Display correct search validation status for schema validator datasets
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids loading the BIDS validator output for schema validator datasets, instead loading this once the validation drop down is clicked. For many datasets this avoids several megabytes of data transfer and potentially expensive API requests until this is actually needed.
A related bug fix is included to more accurately disable creating snapshots when the schema validator output contains errors or the draft has no author values provided.
See #3313