Skip to content

Comments

Back-up meeting notes in repository#130

Merged
keunes merged 1 commit intomainfrom
add-notes
Jun 29, 2025
Merged

Back-up meeting notes in repository#130
keunes merged 1 commit intomainfrom
add-notes

Conversation

@keunes
Copy link
Member

@keunes keunes commented Jun 29, 2025

Back up the meeting notes in the api-specs repository and make them accessible on our main website (via direct links).

@keunes keunes requested a review from Sporiff June 29, 2025 09:39
@netlify
Copy link

netlify bot commented Jun 29, 2025

Deploy Preview for openpodcastapi ready!

Name Link
🔨 Latest commit fa94c8f
🔍 Latest deploy log https://app.netlify.com/projects/openpodcastapi/deploys/6861694e7aa24800089e0275
😎 Deploy Preview https://deploy-preview-130--openpodcastapi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Sporiff
Copy link
Member

Sporiff commented Jun 29, 2025

@keunes Rather than storing these in the public folder (which gets bundled in the build), wouldn't it make more sense to put them in the Wiki?

@keunes
Copy link
Member Author

keunes commented Jun 29, 2025

@Sporiff I was thinking about that but then we can't a) include relative links in the docs and b) we can't attach them to GenAI queries (e.g. GitHub copilot) because they're not part of the repository.

@Sporiff
Copy link
Member

Sporiff commented Jun 29, 2025

@keunes I still think including them in the bundle isn't a good idea. We can just make a new dir called meeting-notes in the root of the repo and put them in there. They won't be bundled in the output that way, but they'll still be in the main repository

@keunes keunes force-pushed the add-notes branch 3 times, most recently from 19884d4 to 454cbb8 Compare June 29, 2025 13:03
@keunes
Copy link
Member Author

keunes commented Jun 29, 2025

Ok, moved to root @Sporiff.

.lycheeignore Outdated
@@ -0,0 +1 @@
^/meeting-notes/.* No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keunes I don't think this works in a .lycheeignore file. I think we need to create a lychee.toml and add

exclude_path = ["meeting-notes"]

@Sporiff
Copy link
Member

Sporiff commented Jun 29, 2025

@keunes Could you also remove the meeting-notes dir from public?

@keunes
Copy link
Member Author

keunes commented Jun 29, 2025

Whoops, sorry for that. Issues fixed @Sporiff.

Copy link
Member

@Sporiff Sporiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keunes LGTM 👍

@keunes keunes merged commit d739974 into main Jun 29, 2025
5 checks passed
@keunes keunes deleted the add-notes branch June 29, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants