Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EFCore 3.1 #335

Merged
merged 101 commits into from
May 9, 2022
Merged

Use EFCore 3.1 #335

merged 101 commits into from
May 9, 2022

Conversation

lindellhugo
Copy link
Contributor

@lindellhugo lindellhugo commented Feb 8, 2022 •
edited by Daniel-Svensson
Loading

Part of #323

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 8, 2022

This pull request introduces 5 alerts and fixes 12 when merging 57ff61f into 88078af - view on LGTM.com

new alerts:

  • 2 for String concatenation in loop
  • 1 for Container contents are never accessed
  • 1 for Useless assignment to local variable
  • 1 for Dereferenced variable may be null

fixed alerts:

  • 12 for Dereferenced variable may be null

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 15, 2022

This pull request introduces 8 alerts when merging 133c9c1 into 7afb0df - view on LGTM.com

new alerts:

  • 2 for Constant condition
  • 2 for String concatenation in loop
  • 2 for Useless assignment to local variable
  • 1 for Container contents are never accessed
  • 1 for Futile conditional

Daniel-Svensson
Daniel-Svensson reviewed May 4, 2022
View reviewed changes
Copy link
Member

@Daniel-Svensson Daniel-Svensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some review comments

src/OpenRiaServices.EntityFramework/Framework/OpenRiaServices.EntityFramework.csproj Outdated Show resolved Hide resolved
src/OpenRiaServices.EntityFramework/Framework/OpenRiaServices.EntityFramework.csproj Outdated Show resolved Hide resolved
src/OpenRiaServices.Server.EntityFrameworkCore/Framework/EFCoreTypeDescriptionContext.cs Outdated Show resolved Hide resolved
src/OpenRiaServices.Server/Test/OpenRiaServices.Server.Test.csproj Outdated Show resolved Hide resolved
src/OpenRiaServices.Tools/Test/TestHelper.cs Show resolved Hide resolved
src/VisualStudio/Tools/Test/DomainServiceWizard/BusinessLogicClassContextTests.cs Show resolved Hide resolved
src/VisualStudio/Tools/Test/TestUtilities/TestHelper.cs Show resolved Hide resolved
.../Desktop/OpenRiaServices.Common.DomainServices.Test/Baselines/Default/EF/Catalog_EFCore.g.cs Show resolved Hide resolved
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 4, 2022

This pull request introduces 11 alerts when merging 8ae297f into 1dd5562 - view on LGTM.com

new alerts:

  • 6 for Constant condition
  • 3 for Useless assignment to local variable
  • 2 for String concatenation in loop

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 5, 2022

This pull request introduces 14 alerts when merging 39acd06 into 1dd5562 - view on LGTM.com

new alerts:

  • 8 for Constant condition
  • 4 for Useless assignment to local variable
  • 2 for String concatenation in loop

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 9, 2022

This pull request introduces 14 alerts when merging 6bc9035 into 1dd5562 - view on LGTM.com

new alerts:

  • 8 for Constant condition
  • 4 for Useless assignment to local variable
  • 2 for String concatenation in loop

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 9, 2022

This pull request introduces 14 alerts and fixes 1 when merging 2764ec6 into 1dd5562 - view on LGTM.com

new alerts:

  • 8 for Constant condition
  • 4 for Useless assignment to local variable
  • 2 for String concatenation in loop

fixed alerts:

  • 1 for Container contents are never accessed

@CLAassistant
Copy link

CLAassistant commented May 9, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 9, 2022

This pull request introduces 14 alerts and fixes 1 when merging 56b14e6 into 1dd5562 - view on LGTM.com

new alerts:

  • 8 for Constant condition
  • 4 for Useless assignment to local variable
  • 2 for String concatenation in loop

fixed alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 9, 2022

This pull request introduces 14 alerts and fixes 1 when merging b255ae5 into 1dd5562 - view on LGTM.com

new alerts:

  • 8 for Constant condition
  • 4 for Useless assignment to local variable
  • 2 for String concatenation in loop

fixed alerts:

  • 1 for Container contents are never accessed

@lindellhugo
Copy link
Contributor Author

Add EF Core 3.1 support

  • Added EFCore versions of relevant EF based projects

  • Added EFCore model for AdventureWorks (partly) and Northwind projects for use in tests

  • Added DataAnotations using FluentAPI for the added models

  • Added test, notably

    • Added code generation tests (OpenRiaServices.Tools.* test projects)
    • Added code generation tests which EF uses Catalog_EFDbCtx.g.cs and similar tests such as Northwind_EF.g.cs/vb

@lindellhugo lindellhugo closed this May 9, 2022
@lindellhugo lindellhugo reopened this May 9, 2022
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 9, 2022

This pull request introduces 14 alerts when merging 9660204 into 1dd5562 - view on LGTM.com

new alerts:

  • 8 for Constant condition
  • 4 for Useless assignment to local variable
  • 2 for String concatenation in loop

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

81.5% 81.5% Coverage
0.0% 0.0% Duplication

@lindellhugo lindellhugo enabled auto-merge (squash) May 9, 2022 13:06
@lindellhugo lindellhugo merged commit e21c391 into OpenRIAServices:main May 9, 2022
@Daniel-Svensson Daniel-Svensson added this to the 5.1 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikoijwall erikoijwall erikoijwall approved these changes

@Daniel-Svensson Daniel-Svensson Daniel-Svensson approved these changes

Assignees

@lindellhugo lindellhugo

Labels
Area-EntityFramework enhancement
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lindellhugo @Daniel-Svensson @CLAassistant @erikoijwall