Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtc.confのバックスラッシュの後にスペースがある場合、urlparam2mapで空白のパラメータがある場合に設定を無視する #271

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Nobu19800
Copy link

Identify the Bug

rtc.confで改行する場合のバックスラッシュの後にスペースがある場合に以下のエラーが発生する。

  File "C:\Python37\lib\site-packages\OpenRTM_aist\Properties.py", line 390, in getProperty
    node = self._getNode(keys, 0, self)
  File "C:\Python37\lib\site-packages\OpenRTM_aist\Properties.py", line 1224, in _getNode
    next = curr.hasKey(keys[index])
IndexError: list index out of range
manager.components.preconnect: ConsoleIn0.out?port=ConsoleOut0.in& \ <-ここにスペースがある
                                                    dataflow_type=push&interface_type=corba_cdr

またurlparam2map関数でパラメータが空白の場合にも同様のエラーが発生する。

manager.components.preconnect: ConsoleIn0.out?port=ConsoleOut0.in& \ 
                                                    dataflow_type=push&interface_type=corba_cdr&<-&だけ記述してパラメータを空白にする。

Description of the Change

  • Propertiesでキーの先頭、末尾の空白文字を削除して空文字だったら設定や取得の処理を行わない。
  • urlparam2map関数で入力文字列が空白の場合、=の左辺が空白の場合はパラメータを設定しないようにした。

Verification

  • Did you succeed the build?
  • No warnings for the build?
  • Have you passed the unit tests?

n-ando
n-ando previously approved these changes Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants