Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3d properties internal rename, multiple material per mesh object support, alpha transparency support, empty data object error fix #261

Merged
merged 21 commits into from
Feb 1, 2024

Conversation

rizzntine
Copy link
Contributor

Renamed from blend_mode to blend_method in accordance with blender internals

Renamed from blend_mode to blend_method in accordance with blender internals
@rizzntine
Copy link
Contributor Author

rizzntine commented Nov 25, 2023

blender_namFE5Ga7j In the W3D Properties panel, the blend mode showed an enum number rather than what it actually represented, and changing this slider value would result in nothing actually happening. blender_kKhYh9KVFs I renamed the blend_mode properties to blend_method, so that it would accurately reflected blender's internal method. This results in the enum displaying as a menu, and changing this also changes the blend mode of the selected material.

Based on makarenk0's implementation, now with alpha transparency support.
+1 Argument to create_vertex_material in \material_import.py
This is to ensure no export errors due to empty object data in certain formats. (One example would be an error thrown on Airfield Imports due to the HOUSECOLOR01 material not having an UV Map attached.)
@rizzntine rizzntine changed the title w3d properties panel: blend_mode fixed to blend_method w3d properties internal rename, multiple material per mesh object support, alpha transparency support, empty data object error fix Dec 5, 2023
@Tarcontar
Copy link
Collaborator

Could you please reupload the images attached?

@rizzntine
Copy link
Contributor Author

Ah, apologies, keep forgetting that with every change the images cdn link also changes.
285604113-f5152ff3-e301-4f9e-b94b-1f84f03d8e6f
This is before
285604204-9719fc3a-2633-4b09-9454-ff8c5b2255b6
This is after, and just in-case that these images also fail, i am attaching an imgur image link as well. https://imgur.com/a/CDQ643T

@Tarcontar
Copy link
Collaborator

Hi @rizzntine, thank you for your contribution!
Could you please update this branch? We fixed CI for 4.0 now

@Tarcontar
Copy link
Collaborator

@rizzntine would it be possible for you to have a look at the failing tests?

@rizzntine
Copy link
Contributor Author

Should be good to go now.

@Tarcontar Tarcontar merged commit 1c3bf35 into OpenSAGE:master Feb 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants