Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CMAKE_CXX_STANDARD overridable (fix #741) #742

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Make CMAKE_CXX_STANDARD overridable (fix #741) #742

merged 1 commit into from
Jan 15, 2024

Conversation

pmai
Copy link
Contributor

@pmai pmai commented Nov 20, 2023 •
edited by jdsika
Loading

fixes #741

@pmai pmai added Quality Quality improvements. ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Nov 20, 2023
@pmai pmai added this to the V3.7.0 milestone Nov 20, 2023
@pmai pmai self-assigned this Nov 20, 2023
@pmai pmai force-pushed the fix/cmake-cxx-defaults branch 2 times, most recently from 95bd86a to 423c0b2 Compare November 22, 2023 08:34
@pmai
Make CMAKE_CXX_STANDARD overridable (fix #741)
a1451fb 
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
@jdsika
Copy link
Contributor

jdsika commented Jan 12, 2024

Can be closed as part of #758 ?

@pmai
Copy link
Contributor Author

pmai commented Jan 12, 2024

Can be closed as part of #758 ?

No, this is a separate matter, #758 just depends on this PR, hence it is already based on the same branch to avoid later merge conflicts. Since this one has already been reviewed, we'll discuss separately.

@jdsika
Copy link
Contributor

jdsika commented Jan 15, 2024

OK, this is good to be merged!

@pmai
Copy link
Contributor Author

pmai commented Jan 15, 2024

CCB 2024-01-15: Merge as-is.

@pmai pmai merged commit 534daf5 into master Jan 15, 2024
6 checks passed
@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Apr 4, 2024
@jdsika
Copy link
Contributor

jdsika commented Apr 23, 2024

Reviewed for v3.7.0

@jdsika jdsika deleted the fix/cmake-cxx-defaults branch April 23, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdsika jdsika jdsika approved these changes

@ThomasNaderBMW ThomasNaderBMW Awaiting requested review from ThomasNaderBMW

Assignees

@pmai pmai

Labels
Quality Quality improvements. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Milestone
V3.7.0
Development

Successfully merging this pull request may close these issues.

Allow Setting CMAKE_CXX_STANDARD via Command Line in CMake
2 participants
@pmai @jdsika