Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate various car types in favor of new alias TYPE_CAR #787

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Deprecate various car types in favor of new alias TYPE_CAR #787

merged 2 commits into from
Apr 4, 2024

Conversation

pmai
Copy link
Contributor

@pmai pmai commented Mar 8, 2024

This is a first result of the harmonization effort across ASAM Open standards

In preparation of additional types we already deprecate some obvious candidates for removal, namely our plethora of car types.

@pmai pmai added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Mar 8, 2024
@pmai pmai added this to the V3.7.0 milestone Mar 8, 2024
@pmai pmai self-assigned this Mar 8, 2024
@pmai pmai added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Mar 8, 2024
jakobkaths
jakobkaths suggested changes Mar 18, 2024
View reviewed changes
osi_object.proto Outdated Show resolved Hide resolved
@pmai pmai force-pushed the harmonization/deprecate-car-types branch from 6180640 to 173e7d7 Compare March 25, 2024 09:20
@tbleher
Copy link
Contributor

tbleher commented Apr 3, 2024

The change looks good to me 👍

@pmai
Copy link
Contributor Author

pmai commented Apr 4, 2024

CCB 2024-04-04: Merge as-is.

pmai and others added 2 commits April 4, 2024 09:22
@pmai
Deprecate various car types in favor of new alias TYPE_CAR
6c20ed4 
This is a result of the harmonization effort across ASAM Open standards

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
@pmai @jakobkaths
Review feedback rewording
7b38bed 
Co-authored-by: jakobkaths <54845080+jakobkaths@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
@pmai pmai force-pushed the harmonization/deprecate-car-types branch from 173e7d7 to 7b38bed Compare April 4, 2024 07:22
@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Apr 4, 2024
thempen
thempen approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@thempen thempen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes let the type better align to other standards. It will still be backward compatible and can be used in the new way through the alias functionality. So I do not see a downside. Therefore I approve this PR.

@pmai pmai merged commit 7afdd1e into master Apr 4, 2024
8 checks passed
@pmai pmai deleted the harmonization/deprecate-car-types branch April 4, 2024 08:54
jdsika
jdsika reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@jdsika jdsika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdsika jdsika jdsika approved these changes

@jakobkaths jakobkaths jakobkaths approved these changes

@thempen thempen thempen approved these changes

Assignees

@pmai pmai

Labels
Harmonisation The Group in the ASAM development project working on harmonisation with other standards. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Milestone
V3.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pmai @tbleher @jdsika @thempen @jakobkaths