Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated documentation on formatting scripts #803

Merged
merged 1 commit into from
May 6, 2024
Merged

Fix outdated documentation on formatting scripts #803

merged 1 commit into from
May 6, 2024

Conversation

thomassedlmayer
Copy link
Contributor

@thomassedlmayer thomassedlmayer commented Apr 15, 2024 •
edited
Loading

Fixes outdated documentation on osi3trace formatting scripts:

  • Fixed folder specification.
  • Fixed default value info for output arg.
  • Removed format arg info.
  • Changed documentation file name and header from plural to singular because there is only one formatting script left.

@thomassedlmayer thomassedlmayer added the Bug Problems in the build system, build scripts, etc or faults in the interface. label Apr 15, 2024
@thomassedlmayer thomassedlmayer added this to the V3.7.0 milestone Apr 15, 2024
@thomassedlmayer thomassedlmayer added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Apr 15, 2024
@thomassedlmayer thomassedlmayer force-pushed the fix/osi3trace_documentation branch 3 times, most recently from 5373884 to 029d793 Compare April 22, 2024 09:38
pmai
pmai approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCB 2024-05-06: Merge as-is.

@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels May 6, 2024
@thomassedlmayer @pmai
Fix outdated documentation on formatting scripts
f4fce53 
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
@pmai pmai force-pushed the fix/osi3trace_documentation branch from 029d793 to f4fce53 Compare May 6, 2024 15:34
@pmai pmai merged commit e64338c into OpenSimulationInterface:master May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClemensLinnhoff ClemensLinnhoff ClemensLinnhoff approved these changes

@PhRosenberger PhRosenberger PhRosenberger approved these changes

@pmai pmai pmai approved these changes

Assignees
No one assigned
Labels
Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Milestone
V3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thomassedlmayer @pmai @PhRosenberger @ClemensLinnhoff