-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove is_globally_unique rule from messages, where it does not make sense #812
base: master
Are you sure you want to change the base?
Remove is_globally_unique rule from messages, where it does not make sense #812
Conversation
…sense. Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, these seem overbroad in some places.
In any case I think just removing the rules and statements, meaning that the uniqueness is now completely undefined seems like the wrong way to go about it. I'd rather refine the definition of globally unique to clarify that cross-type uniqueness is only meant for the groundtruth objects, leaving globally unique to still mean unique across simulation time.
How to handle this the best in terms of the rule names is another question.
Signed-off-by: Clemens Linnhoff <clemens.linnhoff@persival.de>
Signed-off-by: Clemens Linnhoff <clemens.linnhoff@persival.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Reference to a related issue in the repository
#809
Add a description
Removed rule is_globally_unique from messages, where a globally unique ID does not make any sense.
Some IDs depend on the scenario, e.g. object IDs in Ground Truth. Some IDs depend on the map, e.g. lane IDs. And some IDs depend on the sensor setup, e.g. sensor IDs.
I can't think of a reason, why there shouldn't be a moving object with ID 0, a lane with ID 0 and a sensor with ID 0. Therefore, I removed the is_globally_unique rule from every message, that is not a ground truth object.
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: