Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

71 support more top level messages #74

Merged
merged 10 commits into from
Jun 13, 2024
Merged

71 support more top level messages #74

merged 10 commits into from
Jun 13, 2024

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented May 28, 2024 •
edited
Loading

Reference to a related issue in the repository

#71

Add a description

Add TrafficUpdate, TrafficCommandUpdate, TrafficCommand

Check the checklist

  • My code and comments follow the contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-validation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@ClemensLinnhoff
Remove parsing proto.in as osi is build anyways before, so the .proto…
119004e 
… file already exists.

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Add more message types
387460e 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff linked an issue May 28, 2024 that may be closed by this pull request
Support more top-level messages #71
Closed
@ClemensLinnhoff
Formatting
40f542f 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Readd proto.in
dd3f775 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Fix double version schema bug
788666b 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Copy link
Contributor Author

Waiting for OpenSimulationInterface/open-simulation-interface#818 to be merged.

@ClemensLinnhoff ClemensLinnhoff mentioned this pull request Jun 4, 2024
Merged
10 tasks
@ClemensLinnhoff
Merge branch 'master' into 71-support-more-top-level-messages
5ca072e
@ClemensLinnhoff
Update osi to current master
37b4356 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Change osi requirement to current master
e8bc22c 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Add remaining message types and unit tests
614a3cc 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Formatting
2df7776 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review June 11, 2024 08:49
@ClemensLinnhoff ClemensLinnhoff requested a review from jdsika June 11, 2024 08:49
@jdsika jdsika merged commit 160aea1 into master Jun 13, 2024
6 checks passed
@jdsika jdsika deleted the 71-support-more-top-level-messages branch June 13, 2024 07:15
@jdsika
Copy link
Contributor

jdsika commented Jun 13, 2024

resolves #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdsika jdsika jdsika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support more top-level messages
2 participants
@ClemensLinnhoff @jdsika