Skip to content

added redis - rate limiting and made register endpoint secure - issue#16#27

Open
MUHSIN-M-P wants to merge 2 commits intoOpenTekHub:mainfrom
MUHSIN-M-P:feat/db
Open

added redis - rate limiting and made register endpoint secure - issue#16#27
MUHSIN-M-P wants to merge 2 commits intoOpenTekHub:mainfrom
MUHSIN-M-P:feat/db

Conversation

@MUHSIN-M-P
Copy link
Contributor

  • I’ve tested the code locally and it works as expected
  • I’ve added screenshots if applicable
  • I’ve followed the code style and contribution guidelines

📝 Description

this PR added rate limit using redis upstash . i have added example.env file and . for register end point it does n't validate the token created i have added that service also and differentiated token of new user and existing user to prevent the exisiting user sending request.

rate limiting register

@kowshikdontu
Copy link
Contributor

@MUHSIN-M-P
hey , glad you added the redis! we are going ahead fast..I made some changes to your code and raised PR, let's wait for the @Harish-2003 to look into these.

@kowshikdontu
Copy link
Contributor

Hey @MUHSIN-M-P , quick question , have you tested the Redis integration using your actual Upstash credentials? I'm interested to know how to set up those for my further contribution.

@MUHSIN-M-P
Copy link
Contributor Author

yes
i have also added env.example in my pr

@Harish-2003
Copy link
Collaborator

i am not much familirar with reddis but can't we check what data got stored in reddis?

@Harish-2003
Copy link
Collaborator

@MUHSIN-M-P

@MUHSIN-M-P
Copy link
Contributor Author

@Harish-2003 yes we can check what data is stored in reddis, using redis cli. i have used redis_upstash you can view it from the site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants