Increase max size of management password buffer #568
Conversation
As we now allow users to set a management password (for persistent connections), the max size of password should match what openvpn.exe can handle (128 or 4096 bytes depending on build options). Increase the buffer size to 4096 though such large passwords may not work in practice. 127 bytes + NUL, may be a safe upper limit. For the random password used for connections spawned by the GUI, the current size of 15 bytes + NUL is retained. Fixes: OpenVPN#567 Signed-off-by: Selva Nair <selva.nair@gmail.com>
|
@selvanair how can I test the fix? I have tried the files from artifacts |
|
Looks like artifacts use OpenSSL 3.0.2 and 2.6beta uses 3.0.7. Let me fix the artifacts building. |
|
@gitnewcomer Could you try artifacts from https://github.com/lstipakov/openvpn-gui/actions/runs/3764681539 ? This is based on master + openssl version bump. |
Thanks @lstipakov, it works now! :) |
|
We should have beta3 / rc1 before the end of year. Yes I agree, it makes sense to auto-start the service for clean install, should be fixed in OpenVPN/openvpn-build#308. |
|
I suggest to change the way we activate the service install feature. Always install the service and plap binaries, but leave the service feature in the installer unselected by default. Then enabling the service feature during install would mean that service is started (and set to auto-start) even on fresh install, choosing PLAP activation would imply service start. |
As we now allow users to set a management password (for persistent connections), the max size of password should match what openvpn.exe can handle (128 or 4096 bytes depending on build options).
Increase the buffer size to 4096 though such large passwords may not work in practice. 127 bytes + NUL, may be a safe upper limit.
For the random password used for connections spawned by the GUI, the current size of 15 bytes + NUL is retained.
Fixes: #567
Signed-off-by: Selva Nair selva.nair@gmail.com