Build improvements #646
Merged
Build improvements #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we use Visual Studio as generator, CMAKE_BUILD_TYPE doesn't make sense, since configuration (release/debug) is specified on build step, not configure step. Signed-off-by: Lev Stipakov <lev@openvpn.net>
selvanair
reviewed
Aug 29, 2023
|
I would just add ASAN configuration to GHA jobs, but for that one needs to look closer on matrix/jobs thing. |
flichtenheld
requested changes
Sep 4, 2023
CMakeLists.txt
Outdated
| set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /guard:cf /DYNAMICBASE") | ||
|
|
||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4996 /wd4267 /wd4244") | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4996 /wd4267 /wd4244 /wd5072") |
There was a problem hiding this comment.
I really think we should document what these numbers mean here. Sure, I can google it. But a comment would be better.
There was a problem hiding this comment.
I changed the way how ASAN is enabled and this is not needed anymore.
lstipakov
force-pushed
the
build_improvements
branch
from
4127a18
to
1432163
Compare
Add ASAN build configuration, based on debug with ASAN enabled. This might help finding crashes like in OpenVPN#548 Signed-off-by: Lev Stipakov <lev@openvpn.net>
lstipakov
force-pushed
the
build_improvements
branch
from
1432163
to
6a70ad2
Compare
flichtenheld
approved these changes
Sep 4, 2023
MSVC is the only generator we use for CMake. Signed-off-by: Lev Stipakov <lev@openvpn.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.