Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed id referencing in datasources #26

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Fixed id referencing in datasources #26

merged 2 commits into from
Jul 30, 2024

Conversation

michaelfmnk
Copy link
Contributor

No description provided.

@michaelfmnk michaelfmnk requested a review from sahaqaa July 29, 2024 12:55
@michaelfmnk michaelfmnk requested a review from a team as a code owner July 29, 2024 12:55
sahaqaa
sahaqaa approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@sahaqaa sahaqaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sahaqaa
Copy link
Contributor

sahaqaa commented Jul 29, 2024

For reference:

Done:
- cloudconnexa/data_source_connector.go (crashes provider, cannot check ID field) CAPI-260
+ cloudconnexa/data_source_network.go (ID OK)
+ cloudconnexa/data_source_user.go (ID OK)
+ cloudconnexa/data_source_user_group.go (ID OK)
+ cloudconnexa/data_source_host.go (ID OK) CAPI-230
+ cloudconnexa/data_source_application.go (ID OK)
- cloudconnexa/data_source_vpn_region.go (cannot test) CAPI-262
- cloudconnexa/data_source_network_routes.go (cannot test) CAPI-263

Legend: "+" ID ok; "-" some kind of error prevented from testing

@sahaqaa sahaqaa merged commit 4c3ddf7 into main Jul 30, 2024
3 checks passed
@sahaqaa sahaqaa deleted the feature/datasources-refactoring branch July 30, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahaqaa sahaqaa sahaqaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelfmnk @sahaqaa