Skip to content

Conversation

@xcentaurix
Copy link
Contributor

stage 3: reviewed lines 8000 - 20000 (end)

@Huevos
Copy link
Contributor

Huevos commented Jan 14, 2026

You need to be careful not to have merge commits in the PR.

@Huevos
Copy link
Contributor

Huevos commented Jan 14, 2026

Also, some of these commits were previously merged.

It seems you are modifying the dev branch of your repo. You should not be doing that. It should only be used as a tracking branch.

When you want to do a PR you need dev up to date. The easiest way to do that is with the sync button on github. Then fork dev branch to a feature branch and work on the feature branch. Do this every time you want to make a PR.

In the PR there should only be relevant commits.

@Huevos
Copy link
Contributor

Huevos commented Jan 14, 2026

I've added the 2 relevant commits to enigma so closing this now.

@Huevos Huevos closed this Jan 14, 2026
@xcentaurix
Copy link
Contributor Author

thanks for the explanation and help. will try to do better next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants