feat:loading_status_templates #48
Conversation
|
Warning Rate limit exceeded@JarbasAl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 59 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request introduces significant changes to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ovos_PHAL_plugin_system/__init__.py (1)
276-276: Localization consideration for language change message.While
"Language changed to {language_code}"is straightforward, consider making it translatable or localized in case users have not yet switched to the new language. For instance, a user’s UI might still be in a non-English locale while seeing this message in English.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
ovos_PHAL_plugin_system/__init__.py(5 hunks)ovos_PHAL_plugin_system/ui/Reboot.qml(0 hunks)ovos_PHAL_plugin_system/ui/Restart.qml(0 hunks)ovos_PHAL_plugin_system/ui/Shutdown.qml(0 hunks)ovos_PHAL_plugin_system/ui/Status.qml(0 hunks)ovos_PHAL_plugin_system/ui/animations/loading.json(0 hunks)ovos_PHAL_plugin_system/ui/animations/status-fail.json(0 hunks)ovos_PHAL_plugin_system/ui/animations/status-success.json(0 hunks)
💤 Files with no reviewable changes (7)
- ovos_PHAL_plugin_system/ui/Shutdown.qml
- ovos_PHAL_plugin_system/ui/animations/status-success.json
- ovos_PHAL_plugin_system/ui/Restart.qml
- ovos_PHAL_plugin_system/ui/Status.qml
- ovos_PHAL_plugin_system/ui/Reboot.qml
- ovos_PHAL_plugin_system/ui/animations/loading.json
- ovos_PHAL_plugin_system/ui/animations/status-fail.json
🔇 Additional comments (6)
ovos_PHAL_plugin_system/__init__.py (6)
199-199: Proper notification display logic.
The approach of displaying "Clock Synchronized" using show_status_animation is consistent with the new centralized GUI logic, and clearly indicates success. This helps unify user messaging.
208-208: Consistent success animation for SSH enabling.
Following the same pattern with show_status_animation("SSH Enabled", True) ensures a uniform experience. This is aligned with the newly consolidated status animation approach.
218-218: Visual consistency for SSH disabling.
Passing False to show_status_animation typically suggests a different outcome or color-coded animation (i.e., failure or negative action). Ensure downstream code consistently interprets False.
225-227: Loading animation usage is properly consolidated.
Using show_loading_animation("Rebooting", override_animations=True, override_idle=True) for a forced display is consistent with the newly refactored approach. Good job maintaining a single code path for status display.
246-248: Graceful display flow for shutdown.
Similar to reboot, the enforced loading animation for "Shutting Down" appears consistent with the rest of the approach. This helps ensure a clear user experience when shutting down.
283-285: Consistent forced animation for Mycroft/OVOS restart.
show_loading_animation("Restarting", override_animations=True, override_idle=True) aligns well with the other forced animation calls. This ensures a single code path for various loading states.
Revert Changes from OpenVoiceOS#48 that added ovos-config>0.X dependency
Revert Changes from OpenVoiceOS#48 that added ovos-config>0.X dependency
* Refactor into Neon package Revert Changes from OpenVoiceOS#48 that added ovos-config>0.X dependency * Undo changes from OpenVoiceOS#48 that added ovos-config>0.X dependency
companion PR OpenVoiceOS/ovos-bus-client#151 + OpenVoiceOS/ovos-gui#68
Summary by CodeRabbit