-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:fallback_plugins #153
Conversation
similar to WakeWords, allows defining a plugin to load if the primary fails this is DIFFERENT from fallback TTS/STT, it isnt loaded at same time but instead when main plugin fails to load for any reason companion to OpenVoiceOS/ovos-plugin-manager#263
WalkthroughThe changes include significant updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Microphone
participant VAD
participant G2P
participant Translation
User->>Microphone: Request audio input
Microphone->>VAD: Process audio for speech detection
VAD->>G2P: Convert graphemes to phonemes
G2P->>Translation: Translate phonemes to target language
Translation-->>User: Deliver translated output
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Additional comments not posted (12)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #153 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 10
Lines ? 791
Branches ? 0
=====================================
Hits ? 0
Misses ? 791
Partials ? 0 ☔ View full report in Codecov by Sentry. |
@@ -731,7 +745,8 @@ | |||
}, | |||
// turn utterances into phoneme sequences, used to generate mouth movements | |||
"g2p": { | |||
"module": "ovos-g2p-plugin-heuristic-arpa" | |||
"module": "ovos-g2p-plugin-mimic", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: not a breaking change because this fails to load by default
* plugins * debug * feat:fallback_plugins OpenVoiceOS/ovos-config#153 OpenVoiceOS/ovos-plugin-manager#263 * Update requirements.txt
similar to WakeWords, allows defining a plugin to load if the primary fails
this is DIFFERENT from fallback TTS/STT, it isnt loaded at same time but instead when main plugin fails to load for any reason
companion to OpenVoiceOS/ovos-plugin-manager#263
Summary by CodeRabbit
New Features
Bug Fixes