-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial React GUI support #26
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #26 +/- ##
======================================
Coverage ? 52.73%
======================================
Files ? 11
Lines ? 1022
Branches ? 0
======================================
Hits ? 539
Misses ? 483
Partials ? 0 ☔ View full report in Codecov by Sentry. |
@alexisdiaz008 I think this is a good starting point for react support on the core side |
@@ -44,6 +44,8 @@ def get_file_extension(framework: str) -> str: | |||
""" | |||
if framework in ("qt5", "qt6"): | |||
return "qml" | |||
if framework == "react": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there different versions or flavors we should support here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe vue
?
Add core messagebus event forwarding to support current react GUI implementation https://github.com/alexisdiaz008/react-mycroft-gui/blob/master/src/components/mycroft_message_bus_elements/mycroft_message_bus.jsx
e39575c
to
7d6c523
Compare
Troubleshooting react relative resource paths Minor jsx changes
Add file extension mapping for react GUI
Add core messagebus event forwarding to support current react GUI implementation https://github.com/alexisdiaz008/react-mycroft-gui/blob/master/src/components/mycroft_message_bus_elements/mycroft_message_bus.jsx