fix/playback_thread startup #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if using a fallback the thread is started twice fix test fix test missing import Mycroft -> OpenVoiceOS fix type hints feat/tts_transformers . move PlaybackThread to ovos-audio . feat/ovos_dialog_tts_transformers listener has AudioTransformers core has MetadataTransformers and UtteranceTransformers this PR extends the concept to ovos-audio for text before TTS stage, and wav file after TTS but before playback use case demonstration https://gist.github.com/JarbasAl/16788bdcff3fa5bfb3634d6f2116cc04 this ties into OpenVoiceOS/ovos-persona#4
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #180 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 57
Lines ? 3916
Branches ? 0
=====================================
Hits ? 0
Misses ? 3916
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if using a fallback TTS the thread is started twice and throws an exception