fix:cq_speak

[JarbasAl]

Summary by CodeRabbit

• New Features
  • Enhanced skill query handling to immediately speak the answer to the user
• Improvements
  • Optimized the method to prioritize user interaction by speaking the answer before processing callbacks
  • Simplified debug logging for query handling

[coderabbitai]

Walkthrough

The pull request modifies the __handle_skill_query_action method in the OVOSSkill class. The primary change involves adding a speak method call to output the answer derived from the message data before processing any common query callbacks. This modification ensures that the skill speaks the answer to the user first, regardless of whether a callback is registered. The debug logging for cases without a common query callback has been removed, simplifying the method's implementation.

Changes

File	Change Summary
ovos_workshop/skills/ovos.py	Modified __handle_skill_query_action method to prioritize speaking the answer before handling callbacks

Possibly related PRs

• feat: game skill #306: Introduction of OVOSGameSkill class, which shares similar interaction handling principles with the modified skill query action method

Poem

🐰 A Rabbit's Ode to Skill Responses 🗣️

Speak first, then listen, that's the way,
Answers dancing before callbacks play,
Silent logs fade, clarity takes flight,
User interaction shining bright!
Code hops forward with eloquent grace 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.23%. Comparing base (43bfe5b) to head (14bd915).
Report is 9 commits behind head on dev.

Files with missing lines	Patch %	Lines
ovos_workshop/skills/ovos.py	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #321      +/-   ##
==========================================
- Coverage   49.27%   49.23%   -0.05%     
==========================================
  Files          37       37              
  Lines        4426     4434       +8     
==========================================
+ Hits         2181     2183       +2     
- Misses       2245     2251       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

ovos_workshop/skills/ovos.py (2)

1064-1064: Consider handling a None or blank answer.

If the answer value might be None or empty, users will likely experience silence without feedback. For better user clarity, consider adding a quick check for empty answers before calling self.speak(answer):

+ if answer:
+     self.speak(answer)
+ else:
+     LOG.debug("No answer provided; skipping speak()")

---

1066-1068: Revisit user experience when there is no common query callback.

Currently, the flow ends immediately if _cq_callback is not set, which is fine functionally. However, if a user expects further action (e.g., skill chaining or a follow-up prompt), consider providing a fallback or user-friendly message for clarity.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1081fea and 14bd915.

📒 Files selected for processing (1)

• ovos_workshop/skills/ovos.py (1 hunks)