Use DPIC-function to return deferred result #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poemonsense
reviewed
Jan 15, 2024
src/test/vsrc/vcs/DeferredControl.v
Outdated
| if ((~simv_result) && (|step)) begin | ||
| simv_nstep(step); | ||
| end | ||
| if (~reset && (~simv_result) && (|step)) begin |
There was a problem hiding this comment.
Better to use ! instead of ~, step != 0 instead of |step for logic operations.
|
Use one short sentence for the commit title please. See Chisel commits: https://github.com/chipsalliance/chisel/commits/main/ |
klin02
force-pushed
the
deferred-return-result
branch
from
b951c35 to
94717c5
Compare
klin02
changed the title
poemonsense
reviewed
Jan 15, 2024
src/test/vsrc/vcs/DeferredControl.v
Outdated
| if ((~simv_result) && (|step)) begin | ||
| simv_nstep(step); | ||
| end | ||
| if ((!reset) && (!simv_result) && (step != 0)) begin |
There was a problem hiding this comment.
No need for the extra braces () but it's ok
poemonsense
previously approved these changes
Jan 15, 2024
klin02
force-pushed
the
deferred-return-result
branch
from
94717c5 to
97cc8b9
Compare
poemonsense
previously approved these changes
Jan 16, 2024
|
The DPIC-task is contained in GFIFO function，which unsupport output. I will check whether it works |
klin02
force-pushed
the
deferred-return-result
branch
3 times, most recently
from
d767424 to
b948d6c
Compare
Before this commit, we fetch simv_result at 5000 cycles. Only when the result is not zero, it works and stop simulation. Now we use DPIC task to implement the return of simv_result when not zero, so only one DPIC task will be used to stop simulation. That will reduce the cost of fetch and get result return faster.
To return a value in GFIFO function, we can use SFIFO DPIC function to set it. |
poemonsense
approved these changes
Jan 17, 2024
klin02
changed the title
pxk27
pushed a commit
to pxk27/difftest
that referenced
this pull request
Jan 30, 2024
Before this commit, we fetch simv_result at 5000 cycles. Only when the result is not zero, it works and stop simulation. Now we use DPIC function to implement the return of simv_result when not zero, so only one DPIC function will be used to stop simulation. That will reduce the cost of fetch and get result return faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, we fetch simv_result at 5000 cycles. Only when the result is not zero, it works and stop simulation.
Now we use DPIC task to implement the return of simv_result when not zero, so only one DPIC task will be used to stop simulation. That will reduce the cost of fetch and get result return faster.