fix(Makefile): set the default REF to Nemu #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits add the default REF variable with value of Nemu. We intended to record the REF_HOME at compile-time with the REF_HOME macro passed as a C++ flag. However, this detection is wrapped in the `ifneq ($(REF),)` checker and fails to capture NEMU_HOME if the user does not explicitly specify `REF=Nemu`. We also remove the default REF_PROXY variable in config.h.
klin02
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits add the default REF variable with value of Nemu.
We intended to record the REF_HOME at compile-time with the REF_HOME macro passed as a C++ flag. However, this detection is wrapped in the
ifneq ($(REF),)checker and fails to capture NEMU_HOME if the user does not explicitly specifyREF=Nemu.We also remove the default REF_PROXY variable in config.h.