Skip to content

Commit

Permalink
Add ERC721ABI and fix other abis (#761)
Browse files Browse the repository at this point in the history
* fix account abi

* fix erc20 abi

* fix erc721 abi

* reorder internal fns

* reorder internal fns

* fix comment

* reorder fns

* fix casing

* fix casing

* reorder api fns

* add dual interfaces link

* add camel methods to api

* remove imports

* re-add src5_state

* Apply suggestions from code review

Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>

* add deployer trait/impl

* change non-standard to impls in fn list

* fix in-code doc style

* fix comments

* fix interface order

* remove unused impl

---------

Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
  • Loading branch information
andrew-fleming and ericnordelo authored Nov 27, 2023
1 parent d4a44ab commit cd0ce89
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/accounts.adoc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
:test-signers: https://github.com/OpenZeppelin/cairo-contracts/blob/release-v0.6.1/tests/signers.py
:snip-5: https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-5.md
:snip-6: https://github.com/ericnordelo/SNIPs/blob/feat/standard-account/SNIPS/snip-6.md
:counterfactual: xref:/guides/deployment.adoc[Counterfactual deployments]
:counterfactual: xref:/guides/deployment.adoc[counterfactual deployments]

= Accounts

Expand Down
10 changes: 5 additions & 5 deletions src/account/interface.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ trait ISRC6<TState> {
fn is_valid_signature(self: @TState, hash: felt252, signature: Array<felt252>) -> felt252;
}

#[starknet::interface]
trait ISRC6CamelOnly<TState> {
fn isValidSignature(self: @TState, hash: felt252, signature: Array<felt252>) -> felt252;
}

#[starknet::interface]
trait IDeclarer<TState> {
fn __validate_declare__(self: @TState, class_hash: felt252) -> felt252;
Expand All @@ -36,6 +31,11 @@ trait IPublicKey<TState> {
fn set_public_key(ref self: TState, new_public_key: felt252);
}

#[starknet::interface]
trait ISRC6CamelOnly<TState> {
fn isValidSignature(self: @TState, hash: felt252, signature: Array<felt252>) -> felt252;
}

#[starknet::interface]
trait IPublicKeyCamel<TState> {
fn getPublicKey(self: @TState) -> felt252;
Expand Down

0 comments on commit cd0ce89

Please sign in to comment.