Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multisig Docs #1254

Merged
merged 28 commits into from
Dec 18, 2024
Merged

Multisig Docs #1254

merged 28 commits into from
Dec 18, 2024

Conversation

immrsd
Copy link
Collaborator

@immrsd immrsd commented Dec 10, 2024

PR Checklist

  • Documentation

@immrsd immrsd self-assigned this Dec 10, 2024
andrew-fleming
andrew-fleming reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @immrsd! I left some feedback

docs/modules/ROOT/pages/governance/multisig.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/governance.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/governance.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/governance.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/governance.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/governance.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/governance/votes.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/api/governance.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/governance.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/governance.adoc Outdated Show resolved Hide resolved
ericnordelo
ericnordelo reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @immrsd. I subscribe to @andrew-fleming comments on API Reference, and left some (formatting) suggestions on the main page which look very good. I will go though API Reference again after the main fixes are applied.

docs/modules/ROOT/pages/api/governance.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/governance/multisig.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/governance/multisig.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/governance/multisig.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/governance/multisig.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/governance/multisig.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/governance/multisig.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/governance/multisig.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/governance/multisig.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/governance.adoc Show resolved Hide resolved
andrew-fleming
andrew-fleming approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvements look great! I left a final suggestion

docs/modules/ROOT/pages/api/governance.adoc Outdated Show resolved Hide resolved
@immrsd immrsd requested a review from ericnordelo December 18, 2024 07:06
ericnordelo
ericnordelo approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@immrsd immrsd merged commit e28b987 into OpenZeppelin:main Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-fleming andrew-fleming andrew-fleming approved these changes

@ericnordelo ericnordelo ericnordelo approved these changes

@ggonzalez94 ggonzalez94 Awaiting requested review from ggonzalez94

Assignees

@immrsd immrsd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@immrsd @ericnordelo @andrew-fleming