Skip to content

Fix doc example #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix doc example #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7204f
fix: example
ericnordelo Dec 12, 2024
b714b9a
feat: apply review updates
ericnordelo Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/modules/ROOT/pages/governance/governor.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ mod MyGovernor {
use starknet::ContractAddress;

pub const VOTING_DELAY: u64 = 86400; // 1 day
pub const VOTING_PERIOD: u64 = 432_000; // 1 week
pub const VOTING_PERIOD: u64 = 604800; // 1 week
pub const PROPOSAL_THRESHOLD: u256 = 10;
pub const QUORUM_NUMERATOR: u256 = 40; // 4%

Expand Down Expand Up @@ -269,7 +269,7 @@ pub mod MyTimelockedGovernor {
use starknet::ContractAddress;

pub const VOTING_DELAY: u64 = 86400; // 1 day
pub const VOTING_PERIOD: u64 = 432_000; // 1 week
pub const VOTING_PERIOD: u64 = 604800; // 1 week
pub const PROPOSAL_THRESHOLD: u256 = 10;
pub const QUORUM: u256 = 100_000_000;

Expand Down
6 changes: 3 additions & 3 deletions packages/test_common/src/mocks/governor.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ pub mod GovernorMock {
use starknet::ContractAddress;

pub const VOTING_DELAY: u64 = 86400; // 1 day
pub const VOTING_PERIOD: u64 = 432_000; // 1 week
pub const VOTING_PERIOD: u64 = 604800; // 1 week
pub const PROPOSAL_THRESHOLD: u256 = 10;
pub const QUORUM: u256 = 100_000_000;

Expand Down Expand Up @@ -145,7 +145,7 @@ pub mod GovernorQuorumFractionMock {
use starknet::ContractAddress;

pub const VOTING_DELAY: u64 = 86400; // 1 day
pub const VOTING_PERIOD: u64 = 432_000; // 1 week
pub const VOTING_PERIOD: u64 = 604800; // 1 week
pub const PROPOSAL_THRESHOLD: u256 = 10;
pub const QUORUM_NUMERATOR: u256 = 600; // 60%

Expand Down Expand Up @@ -275,7 +275,7 @@ pub mod GovernorTimelockedMock {
use starknet::ContractAddress;

pub const VOTING_DELAY: u64 = 86400; // 1 day
pub const VOTING_PERIOD: u64 = 432_000; // 1 week
pub const VOTING_PERIOD: u64 = 604800; // 1 week
pub const PROPOSAL_THRESHOLD: u256 = 10;
pub const QUORUM: u256 = 100_000_000;

Expand Down
Loading