fix: Fix incorrect use of contract.update Update get_hashes_page.py #1264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
remove_prefix_from_names
function, theupdate()
method was incorrectly used on thecontract
object. Theupdate()
method is not applicable to dictionaries in this context, as it expects a dictionary or key-value pairs, butremove_prefix
returns a string, not a dictionary.The corrected line now directly updates the
contract['name']
key with the result fromremove_prefix
, like so:This change ensures that the
name
field is properly updated without causing errors, improving the function's correctness.Additional Notes
contract.update(...)
was attempting to assign a string to the dictionary in an incorrect manner.contract['name']
field, which is the intended behavior.PR Checklist