Skip to content

fix: Improve Prefix Handling and Input Validation in Utility Functions#1270

Closed
ursulabauer wants to merge 1 commit intoOpenZeppelin:mainfrom
ursulabauer:patch-1
Closed

fix: Improve Prefix Handling and Input Validation in Utility Functions#1270
ursulabauer wants to merge 1 commit intoOpenZeppelin:mainfrom
ursulabauer:patch-1

Conversation

@ursulabauer
Copy link
Copy Markdown

Hi team,

I’ve addressed a couple of issues in the remove_prefix_from_names and normalize_len functions:

  1. Fixed typos that caused unexpected behavior in specific edge cases.
  2. Added input and argument validations to ensure the functions are more resilient to improper usage.
  3. Improved error handling for better clarity when something goes wrong.

With these updates, the code should now be more robust and user-friendly. Let me know if there’s anything else I can refine!

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

@ericnordelo
Copy link
Copy Markdown
Member

Hey, thanks for the interest in contributing. We don't think this script needs to be updated. We recommend contributors to open an issue and start a discussion with the maintainers before opening a PR in the repo so we can understand and discuss the issue first.

@ericnordelo ericnordelo closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants