Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initializer_no_metadata to erc721 component #1278

Open
wants to merge 5 commits into
base: release-v1.0.0
Choose a base branch
from

Conversation

andrew-fleming
Copy link
Collaborator

Fixes #1260.

*Wizard needs to be updated with this when released

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-v1.0.0@072f6e4). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release-v1.0.0    #1278   +/-   ##
=================================================
  Coverage                  ?   95.21%           
=================================================
  Files                     ?       59           
  Lines                     ?     1483           
  Branches                  ?        0           
=================================================
  Hits                      ?     1412           
  Misses                    ?       71           
  Partials                  ?        0           
Files with missing lines Coverage Δ
packages/token/src/erc721/erc721.cairo 88.78% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072f6e4...d45e05a. Read the comment docs.

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants