-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macros package and the with_components macro #1282
Open
ericnordelo
wants to merge
20
commits into
OpenZeppelin:main
Choose a base branch
from
ericnordelo:feat/add-macros-package
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add macros package and the with_components macro #1282
ericnordelo
wants to merge
20
commits into
OpenZeppelin:main
from
ericnordelo:feat/add-macros-package
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat/add-macros-package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickstart #1258
NOTE: A summary of the features included in the macro is added below after the example:
Example:
Simplifies this:
Into this:
Summary of features:
IT DOES:
use openzeppelin_access::ownable::OwnableComponent;
)component!(path: OwnableComponent, storage: ownable, event: OwnableEvent);
).impl OwnableInternalImpl = OwnableComponent::InternalImpl<ContractState>;
)ownable: OwnableComponent::Storage,
)IT DOES NOT:
Things to be considered still:
openzeppelin_access
vsopenzeppelin::access
in use clauses (configurable notation?)Some may be addressed in different PRs/issues.
NOTE: I have plans to include a
with_component
macro which will accept only a single component but more configuration, like replacing the storage entry. People then may use both macros together (with_components
andwith_component
)PR Checklist