Skip to content

Commit

Permalink
Use actions v4 and Node 18 for tests (#300)
Browse files Browse the repository at this point in the history
  • Loading branch information
ericglau authored Oct 24, 2023
1 parent ec4d61c commit 285749a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 18.x
cache: 'yarn'
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/zip-hardhat.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ async function extractAndRunPackage(zip: JSZip, c: Contract, t: ExecutionContext
}
}

let command = `cd "${tempFolder}" && npm config set scripts-prepend-node-path auto && npm install && npm test`;
let command = `cd "${tempFolder}" && npm install && npm test`;
if (c.constructorArgs === undefined) {
// only test deploying the contract if there are no constructor args needed
command += ' && npx hardhat run scripts/deploy.ts';
Expand Down

0 comments on commit 285749a

Please sign in to comment.