Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use named imports for Solidity #411

Merged
merged 18 commits into from
Nov 20, 2024
Merged

Conversation

ericglau
Copy link
Member

@ericglau ericglau commented Nov 19, 2024

  • Use named imports
  • Sort imports by name

See preview: https://deploy-preview-411--openzeppelin-contracts-wizard.netlify.app/

Fixes #352

@ericglau ericglau marked this pull request as ready for review November 19, 2024 16:53
@ericglau ericglau requested a review from a team November 19, 2024 16:54
Copy link

socket-security bot commented Nov 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/istanbul-lib-coverage@2.0.6 None 0 5.45 kB types
npm/@types/istanbul-lib-report@3.0.3 None 0 7.92 kB types
npm/@types/istanbul-reports@1.1.2 None 0 4.02 kB types
npm/@types/node@18.19.64 None +1 2.1 MB types
npm/@types/semver@7.5.8 None 0 23.3 kB types
npm/@types/yargs-parser@21.0.3 None 0 8.65 kB types
npm/@types/yargs@13.0.12 None 0 50.4 kB types
npm/ansi-regex@4.1.1 None 0 5.17 kB qix
npm/array.prototype.flat@1.3.2 None +52 3.44 MB ljharb
npm/array.prototype.flatmap@1.3.2 None +52 3.44 MB ljharb
npm/ava@6.2.0 Transitive: environment, eval, filesystem, network, shell, unsafe +120 6.65 MB novemberborn
npm/bluebird@3.7.2 environment, eval, unsafe 0 632 kB esailija
npm/camelcase@5.3.1 None 0 7.45 kB sindresorhus
npm/cliui@5.0.0 None +1 18.8 kB bcoe
npm/cross-spawn@6.0.6 None 0 18.3 kB satazor
npm/decamelize@1.2.0 None 0 2.94 kB sindresorhus
npm/emoji-regex@7.0.3 None 0 36.3 kB mathias
npm/end-of-stream@1.4.4 None 0 6.23 kB mafintosh
npm/ethereum-cryptography@3.0.0 None +4 2.83 MB paulmillr
npm/execa@1.0.0 environment, shell 0 19.9 kB sindresorhus
npm/find-up@3.0.0 None 0 4.84 kB sindresorhus
npm/get-stream@4.1.0 None 0 7.88 kB sindresorhus
npm/is-stream@1.1.0 None 0 3.23 kB sindresorhus
npm/jest-changed-files@24.9.0 environment +1 27.3 kB scotthovestadt
npm/locate-path@3.0.0 None 0 3.87 kB sindresorhus
npm/nice-try@1.0.5 None 0 3.75 kB electerious
npm/npm-run-path@2.0.2 environment +1 7.55 kB sindresorhus
npm/p-finally@1.0.0 None 0 3.11 kB sindresorhus
npm/p-limit@2.3.0 None 0 7.39 kB sindresorhus
npm/p-locate@3.0.0 None 0 5.05 kB sindresorhus
npm/p-try@2.2.0 None 0 4.37 kB sindresorhus
npm/path-exists@3.0.0 filesystem 0 3.32 kB sindresorhus
npm/pump@3.0.2 None 0 8.76 kB mafintosh
npm/require-main-filename@2.0.0 None 0 3.93 kB bcoe
npm/rimraf@5.0.10 environment, filesystem Transitive: shell +23 3.59 MB isaacs
npm/set-blocking@2.0.0 None 0 4.22 kB bcoe
npm/shebang-command@1.2.0 None 0 2.69 kB kevva
npm/shebang-regex@1.0.0 None 0 2.3 kB sindresorhus
npm/signal-exit@3.0.7 None 0 9.96 kB isaacs
npm/split@1.0.1 None 0 12.3 kB dominictarr
npm/strip-eof@1.0.0 None 0 2.64 kB sindresorhus
npm/through@2.3.8 None 0 12.5 kB dominictarr
npm/typescript@4.9.5 None 0 66.8 MB typescript-bot
npm/which-module@2.0.1 None 0 4.04 kB nexdrew
npm/wrap-ansi@5.1.0 None 0 9.62 kB sindresorhus
npm/wsrun@5.2.4 environment, filesystem, shell 0 70.5 kB ivasilov
npm/y18n@4.0.3 filesystem 0 11 kB oss-bot
npm/yargs-parser@13.1.2 environment 0 57.1 kB oss-bot
npm/yargs@13.3.2 environment, filesystem 0 229 kB oss-bot

🚮 Removed packages: npm/@openzeppelin/contracts-upgradeable@5.1.0, npm/@openzeppelin/hardhat-upgrades@3.5.0

View full report↗︎

Copy link

socket-security bot commented Nov 20, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/cross-spawn@6.0.6

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@ericglau
Copy link
Member Author

@SocketSecurity ignore npm/cross-spawn@6.0.6

Unrelated to this PR.

@ericglau
Copy link
Member Author

Ready for review.

@ericglau ericglau merged commit 6263afc into OpenZeppelin:master Nov 20, 2024
9 checks passed
@ericglau ericglau deleted the namedimports branch November 20, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use named imports for Solidity
2 participants