Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SRC9 option to Cairo accounts #422

Merged

Conversation

ericnordelo
Copy link
Member

No description provided.

Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Can you add a changelog entry and bump package.json version? I think it can be version 0.20.1.

packages/core-cairo/src/account.test.ts Show resolved Hide resolved
@ericnordelo ericnordelo requested a review from ericglau December 17, 2024 10:53
Copy link

socket-security bot commented Dec 17, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nomicfoundation/hardhat-toolbox@5.0.0 environment Transitive: eval, filesystem, network, shell, unsafe +775 226 MB kanej
npm/@openzeppelin/hardhat-upgrades@3.6.0 filesystem Transitive: environment, eval, network, unsafe +78 17.8 MB ericglau
npm/hardhat@2.22.16 environment, filesystem, network, shell Transitive: eval, unsafe +386 243 MB kanej

🚮 Removed packages: npm/@rollup/plugin-alias@5.1.1, npm/@rollup/plugin-commonjs@28.0.2, npm/@rollup/plugin-json@6.1.0, npm/@rollup/plugin-node-resolve@15.3.1, npm/@rollup/plugin-replace@5.0.7, npm/@rollup/plugin-typescript@11.1.6, npm/@types/file-saver@2.0.7, npm/@types/istanbul-lib-coverage@2.0.6, npm/@types/istanbul-lib-report@3.0.3, npm/@types/istanbul-reports@1.1.2, npm/@types/node@18.19.68, npm/@types/resize-observer-browser@0.1.11, npm/@types/semver@7.5.8, npm/@types/yargs-parser@21.0.3, npm/@types/yargs@13.0.12, npm/ansi-regex@4.1.1, npm/array.prototype.flat@1.3.3, npm/array.prototype.flatmap@1.3.3, npm/autoprefixer@10.4.20, npm/ava@6.2.0, npm/bluebird@3.7.2, npm/camelcase@5.3.1, npm/cliui@5.0.0, npm/cross-spawn@6.0.6, npm/decamelize@1.2.0, npm/emoji-regex@7.0.3, npm/end-of-stream@1.4.4, npm/ethereum-cryptography@3.0.0, npm/execa@1.0.0, npm/find-up@3.0.0, npm/get-stream@4.1.0, npm/hardhat@2.22.17, npm/is-stream@1.1.0, npm/jest-changed-files@24.9.0, npm/jszip@3.10.1, npm/locate-path@3.0.0, npm/nice-try@1.0.5, npm/npm-run-path@2.0.2, npm/p-finally@1.0.0, npm/p-limit@2.3.0, npm/p-locate@3.0.0, npm/p-try@2.2.0, npm/path-exists@3.0.0, npm/pump@3.0.2, npm/require-main-filename@2.0.0, npm/rimraf@5.0.10, npm/set-blocking@2.0.0, npm/shebang-command@1.2.0, npm/shebang-regex@1.0.0, npm/signal-exit@3.0.7, npm/solidity-ast@0.4.59, npm/split@1.0.1, npm/strip-eof@1.0.0, npm/through@2.3.8, npm/typescript@4.9.5, npm/which-module@2.0.1, npm/wrap-ansi@5.1.0, npm/wsrun@5.2.4, npm/y18n@4.0.3, npm/yargs-parser@13.1.2, npm/yargs@13.3.2

View full report↗︎

packages/core-cairo/package.json Outdated Show resolved Hide resolved
Co-authored-by: Eric Lau <ericglau@outlook.com>
Copy link

socket-security bot commented Dec 17, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/ws@7.4.6

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@ericglau
Copy link
Member

@SocketSecurity ignore npm/ws@7.4.6

Unrelated to this PR.

@ericnordelo ericnordelo merged commit a2df7c3 into OpenZeppelin:master Dec 17, 2024
9 checks passed
@ericnordelo ericnordelo deleted the feat/add-src9-to-cairo-account branch December 17, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants