Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typographical Errors in Contracts and Tests #5402

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Typographical Errors in Contracts and Tests #5402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5e5c58
typo ERC2981.sol
Marcofann Dec 24, 2024
682b939
typo TransientSlot.sol
Marcofann Dec 24, 2024
5d86491
typos ERC2771Forwarder.t.sol
Marcofann Dec 24, 2024
af71696
typos Arrays.sol
Marcofann Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/token/common/ERC2981.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ abstract contract ERC2981 is IERC2981, ERC165 {
error ERC2981InvalidDefaultRoyaltyReceiver(address receiver);

/**
* @dev The royalty set for an specific `tokenId` is invalid (eg. (numerator / denominator) >= 1).
* @dev The royalty set for a specific `tokenId` is invalid (eg. (numerator / denominator) >= 1).
*/
error ERC2981InvalidTokenRoyalty(uint256 tokenId, uint256 numerator, uint256 denominator);

Expand Down
6 changes: 3 additions & 3 deletions contracts/utils/Arrays.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ library Arrays {
}

/**
* @dev Helper to set the length of an dynamic array. Directly writing to `.length` is forbidden.
* @dev Helper to set the length of a dynamic array. Directly writing to `.length` is forbidden.
*
* WARNING: this does not clear elements if length is reduced, of initialize elements if length is increased.
*/
Expand All @@ -459,7 +459,7 @@ library Arrays {
}

/**
* @dev Helper to set the length of an dynamic array. Directly writing to `.length` is forbidden.
* @dev Helper to set the length of a dynamic array. Directly writing to `.length` is forbidden.
*
* WARNING: this does not clear elements if length is reduced, of initialize elements if length is increased.
*/
Expand All @@ -470,7 +470,7 @@ library Arrays {
}

/**
* @dev Helper to set the length of an dynamic array. Directly writing to `.length` is forbidden.
* @dev Helper to set the length of a dynamic array. Directly writing to `.length` is forbidden.
*
* WARNING: this does not clear elements if length is reduced, of initialize elements if length is increased.
*/
Expand Down
2 changes: 1 addition & 1 deletion contracts/utils/TransientSlot.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pragma solidity ^0.8.24;
*/
library TransientSlot {
/**
* @dev UDVT that represent a slot holding a address.
* @dev UDVT that represent a slot holding an address.
*/
type AddressSlot is bytes32;

Expand Down
6 changes: 3 additions & 3 deletions test/metatx/ERC2771Forwarder.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ contract ERC2771ForwarderTest is Test {
uint256 refundExpected = 0;
uint256 nonce = _erc2771Forwarder.nonces(_signer);

// create an sign array or requests (that may fail)
// create a sign array or requests (that may fail)
ERC2771Forwarder.ForwardRequestData[] memory requests = new ERC2771Forwarder.ForwardRequestData[](batchSize);
for (uint256 i = 0; i < batchSize; ++i) {
bool failure = (seed >> i) & 0x1 == 0x1;
Expand Down Expand Up @@ -229,7 +229,7 @@ contract ERC2771ForwarderTest is Test {
TamperType tamper = _asTamper(_tamper);
uint256 nonce = _erc2771Forwarder.nonces(_signer);

// create an sign array or requests
// create a sign array or requests
ERC2771Forwarder.ForwardRequestData[] memory requests = new ERC2771Forwarder.ForwardRequestData[](3);
for (uint256 i = 0; i < requests.length; ++i) {
requests[i] = _forgeRequestData({
Expand All @@ -252,7 +252,7 @@ contract ERC2771ForwarderTest is Test {
TamperType tamper = _asTamper(_tamper);
uint256 nonce = _erc2771Forwarder.nonces(_signer);

// create an sign array or requests
// create a sign array or requests
ERC2771Forwarder.ForwardRequestData[] memory requests = new ERC2771Forwarder.ForwardRequestData[](3);
for (uint256 i = 0; i < requests.length; ++i) {
requests[i] = _forgeRequestData({
Expand Down
Loading