-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add inline comments to pallet grouping macro expansions #47
docs: Add inline comments to pallet grouping macro expansions #47
Conversation
Hi @4meta5! I have pushed changes for all groups with some exceptions for which I couldn't find any relevant docs. Would be great if you could help with those. Assets
EVM
Tanssi
XCM
|
@4meta5 lets close this? |
@4meta5 thanks for the review. What to do for the pallets mentioned in the above comment? |
Created this follow up issue: #55 for the pallets not covered by this PR. Thanks for your contribution! |
The testing error is because there are no tests to run which have become an error now (was a warning previously). Test failure now:
Old behaviour in the last successful PR merged
We could either pass the |
@4meta5 done |
@4meta5 Lets wrap this up I suppose, the CI should be green now Thanks! |
de51780
to
0792f71
Compare
Rebased off main, resolved conflictts |
On it |
@KitHat @ggonzalez94 please lend a 2nd pair of eyes to confirm that no code configs have been changed, I just did another quick skim but it is a lot of LOC changed :) |
Pushed changes Apologies for so much back and forth 🤧 |
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
dd27432
to
5aa1c2c
Compare
Thank you for your perseverance @mittal-parth |
Thanks for your patience too! @4meta5 Lemme know if I can help with something else :) |
Fixes #24
Adds inline comments to the various pallet grouping macro expansions.
PR Checklist