Skip to content

Commit

Permalink
Clarify testcase names
Browse files Browse the repository at this point in the history
  • Loading branch information
ericglau committed Sep 23, 2024
1 parent 8cfa3a9 commit 31d1073
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/core/src/infer-proxy-admin.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ test('inferProxyAdmin returns true when owner looks like an address', async t =>
t.true(await inferProxyAdmin(provider, addr));
});

test('inferProxyAdmin returns false when returned value has is more than 20 bytes', async t => {
test('inferProxyAdmin returns false when returned value is 32 bytes but clearly not an address', async t => {
// some higher order byte beyond 20 bytes is non-zero
const provider = makeProviderReturning('0x0000000000000000000000011000000000000000000000000000000000000123');
t.false(await inferProxyAdmin(provider, addr));
});

test('inferProxyAdmin returns false when owner is a string', async t => {
test('inferProxyAdmin returns false when returned value is a string', async t => {
// abi encoding of string 'foo'
const provider = makeProviderReturning(
'0x00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000003666f6f0000000000000000000000000000000000000000000000000000000000',
Expand Down

0 comments on commit 31d1073

Please sign in to comment.