Leave constants as is when making namespaced input #1009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977
The plugin makes a modified copy of the solc input in order to extract types for namespaced struct definitions.
For variable declarations, we normally convert them to dummy enums since they aren't needed, but we avoid deleting them to avoid messing up NatSpec associations as explained in #918 (comment).
However, constants could be referenced in a struct definition as demonstrated in #977. These could also be used in namespaced structs. So for constants, we should not convert them to enums but leave them as is.