-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check to ensure initialOwner
is not a ProxyAdmin contract when deploying a transparent proxy
#1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@openzeppelin/upgrades-core@1.37.1 |
Amxx
reviewed
Sep 23, 2024
Amxx
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With OpenZeppelin Contracts v5, the
initialOwner
when deploying a transparent proxy must not be a predeployed ProxyAdmin contract. The transparent proxy deploys its own ProxyAdmin using thisinitialOwner
as the owner, therefore theinitialOwner
must be an EOA or a contract that is able to call functions on a ProxyAdmin.This PR adds the following check: if the
initialOwner
when deploying a transparent proxy is a contract that has anowner()
getter which returns something that looks like an address, it might be a ProxyAdmin contract. In this case, throw an error.It may have false positives if the
initialOwner
is some other contract (such as a smart account) which has an owner. If this false positive occurs and the user is sure that theinitialOwner
is a contract that can invoke functions on a ProxyAdmin but is not a ProxyAdmin itself, this check can be skipped with theunsafeSkipProxyAdminCheck
option.Hardhat equivalent of OpenZeppelin/openzeppelin-foundry-upgrades#76